WordPress.org

Making WordPress.org

Opened 4 weeks ago

Last modified 4 days ago

#4701 new defect

Streamline access to the changelog content of plugin pages

Reported by: netpassprodsr Owned by:
Milestone: Priority: normal
Component: Plugin Directory Keywords: has-patch
Cc:

Description

The quick:

The following snippet of code is in the wrong place. It should ideally be the final element just before the closing <article> tag on the page, not above the content it references.

<script type="text/javascript">if ( '#changelog' == window.location.hash ) { window.location.hash = '#developers'; }</script>

(this snippet immediately precedes the following group of tags, and because of which it does not produce the desired result:)

<span id="description"></span>
<span id="reviews"></span>
<span id="installation"></span>
<span id="developers"></span>

The details:

The WP Toolkit for Plesk presents links to the plugin pages of those with an updated version available. The link has a reference to changelog, as in this example:

https://wordpress.org/plugins/akismet/changelog/

An automatic reformat of the URL occurs resulting in this link:

https://wordpress.org/plugins/akismet/#changelog

Prior to mid-July 2019, the behavior of the WordPress.org plugins directory would be to simply present the first tab (description) content, so the user then needed to click the Development tab to see the changelog details.

Since then, the script snippet above was inserted to attempt making the Development tab content appear when arriving at the page via a changelog URL.
While the URL in the browser does change, that change is ineffective because the new URL refers to elements not existing when it changes.
(Interestingly, if the page is immediately refreshed in the browser, the Development tab content does indeed appear.)

I propose 1 of 2 resolves to this issue:

  1. Move the script snippet to be the last element before the close of the article html block,

OR

  1. Wrap the script content in some deferred logic structure (e.g., window.onload() or similar) so it runs after the page is loaded.

Attachments (1)

4701.diff (1.2 KB) - added by netpassprodsr 10 days ago.
single line relocation to accomplish the fix

Download all attachments as: .zip

Change History (8)

#1 @Otto42
4 weeks ago

The development tab appears for me regardless of the location of the script on the page.

This "fix" appears to work correctly.

#2 @netpassprodsr
4 weeks ago

My platform configuration: (this should have been part of the original ticket submission.)
OS: Windows 10 Pro, 1903 Edition
Browser: Firefox Quantum 68.0.2 (64-bit)

I can reliably reproduce the experience accessing different plugin pages.

This ticket was mentioned in Slack in #meta by sergey. View the logs.


3 weeks ago

#4 @SergeyBiryukov
3 weeks ago

Hi @netpassprodsr, welcome to WordPress Meta Trac!

Thanks for the ticket, I was able to reproduce the issue. The current snippet shows the correct tab in Chrome, but not in Firefox (until a page refresh).

@netpassprodsr
10 days ago

single line relocation to accomplish the fix

#5 @netpassprodsr
10 days ago

  • Keywords has-patch added

This ticket was mentioned in Slack in #meta by netpassprodsr. View the logs.


7 days ago

This ticket was mentioned in Slack in #meta by netpassprodsr. View the logs.


4 days ago

Note: See TracTickets for help on using tickets.