WordPress.org

Making WordPress.org

Opened 5 years ago

Closed 5 years ago

#478 closed defect (fixed)

WordPress Theme API Returning Broken Image

Reported by: downstairsdev Owned by: Otto42
Milestone: Priority: high
Component: API Keywords:
Cc:

Description

If you search for "Portfolio Press" from the themes page of the WordPress dashboard it returns a broken image for my theme (http://wordpress.org/themes/portfolio-press).

I think this has to do with the recent update we did to allow .jpg images to be used as the screenshot. My guess is that http://api.wordpress.org/themes/info/1.0/ automatically displays screenshot.png and doesn't check for screenshot.jpg.

Attachments (1)

Screen Shot 2014-05-17 at 9.43.32 AM.png (193.6 KB) - added by downstairsdev 5 years ago.

Download all attachments as: .zip

Change History (9)

#1 @downstairsdev
5 years ago

  • Cc devin@… added

#2 @downstairsdev
5 years ago

cc @otto42 by request.

#3 @iandunn
5 years ago

Yeah, it's trying to pull screenshot.png and getting a 404.

#4 @Otto42
5 years ago

Looks like we need to save the information about the screenshot name as meta at the time of the upload, then output the correct name from that later. I'll look into adding it.

#5 @Otto42
5 years ago

  • Owner set to Otto42
  • Priority changed from normal to high
  • Status changed from new to assigned

#6 @Otto42
5 years ago

Theme directory should be showing JPG preferentially now, if the file exists. This determination is made at the time of the theme's approval, so if a screenshot.jpg exists then, it will use it, else it will fallback to the png file.

Portfolio Press was my test subject here, so it should be showing the JPG now. Still need to check the API response, but the themes directory is using the JPG at this point.

#7 @downstairsdev
5 years ago

Great! Thanks Otto.

#8 @Otto42
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

API response updated to reflect new screenshot info. Side effect, the URL is now a CDN hit instead of a direct one, and it should also be more SSL friendly.

I'm going to close this as fixed, for now. If other places where this happens are found, please re-open with info.

Note: See TracTickets for help on using tickets.