Making WordPress.org

Opened 5 years ago

Closed 5 years ago

#4936 closed defect (bug) (fixed)

The alignment issue with info shortcodes on handbook pages

Reported by: dilipbheda's profile dilipbheda Owned by: coffee2code's profile coffee2code
Milestone: Priority: normal
Component: Handbooks Keywords: needs-patch
Cc:

Description

I have found this small issue on the Plugin Developer FAQ page.
Plugin Developer FAQ: https://developer.wordpress.org/plugins/wordpress-org/plugin-developer-faq/

Thanks.

Attachments (1)

plugin-handbook.png (112.1 KB) - added by dilipbheda 5 years ago.

Download all attachments as: .zip

Change History (4)

#1 @Ipstenu
5 years ago

  • Summary changed from The alignment issue on the plugin handbook page. to The alignment issue with info shortcodes on handbook pages

You can also see it here:

https://make.wordpress.org/docs/handbook/documentation-team-handbook/handbooks-style-and-formatting-guide/

This is an issue with the handbook shortcodes, and not specific to any one team. Updated title to clarify.

#2 @dufresnesteven
5 years ago

The problem exists because the content in the notice should be wrapped in a <p> tag based on the CSS.

A quick look into the Handbook plugin code suggests that its added in the content as I don't seen any difference between the other types of notices.

(https://meta.svn.wordpress.org/sites/trunk/wordpress.org/public_html/wp-content/plugins/handbook/inc/callout-boxes.php)?

#3 @coffee2code
5 years ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 9407:

Handbook plugin: Ensure proper spacing within callouts also apply for single-line shortcodes rendered via shortcode blocks.

For single-line shortcodes added via the shortcode block, the efforts of wpautop() appear to be stripped prior to display so spacing should not rely on presence of any 'p' tags.

Props dilipbheda, dufresnesteven, coffee2code.
Fixes #4936.

Note: See TracTickets for help on using tickets.