WordPress.org

Making WordPress.org

Opened 3 months ago

Last modified 3 days ago

#5172 new defect

Dashicons: Add missing ones and the upcoming ones for WP 5.5

Reported by: casiepa Owned by:
Milestone: Priority: normal
Component: Developer Hub Keywords: has-patch
Cc:

Description

Some issues with the dashicons page on https://developer.wordpress.org/resource/dashicons/

  • A few icons from the current WP version seems to be missing
  • the bbPress icon has the wrong code mentioned
  • the upcoming 5.5 ones are missing (so people do not create pull requests for ones already done)

Change History (11)

This ticket was mentioned in PR #6 on WordPress/wordpress.org by ePascalC.


3 months ago

https://meta.trac.wordpress.org/ticket/5172
Fixed bbPress icon code
Added some missing icons from releases up to WP 5.4
Added the upcoming WP 5.5 dashicons

#2 @casiepa
3 months ago

  • Keywords has-patch added

#3 @dd32
3 months ago

In 9776:

Developer: Include the 'category'/Group of the icons in the glyph preview.

This allows for users to know which group of icons a search result belongs to.

See #5172.

#4 @dd32
3 months ago

In 9777:

Developer: Make r9776 work when selecting the first dashicon in a section.

See #5172.

#5 @dd32
3 months ago

In 9778:

Developer: Dashicons: Correct some dashicons and add the new ones.

Props casiepa.
See https://github.com/WordPress/wordpress.org/pull/6
See #5172.

#6 @dd32
3 months ago

Adding the 5.5+ dashicons will have to wait until Core is updated with the new dashicons, since we use trunk's dashicons.css file.

[9776]/[9777] were intended to allow adding the 5.5+ section and having some kind of note show up in the upper glyph section to indicate that it would only be available in 5.5 when using the search functionality.

#7 @desrosj
8 days ago

Just came across this ticket. It does not appear that Dashicons has been updated for 5.5. I found https://core.trac.wordpress.org/ticket/49913, which lines up time wise and appears to be the update this ticket is referring to, but it was never put into the 5.5 milestone.

As this ticket is an enhancement ticket, a special exception would need to be made as feature requests and enhancements are not allowed after beta 1.

Is this dashicons update essential for 5.5?

This ticket was mentioned in Slack in #design-dashicons by casiepa. View the logs.


7 days ago

This ticket was mentioned in Slack in #design-dashicons by casiepa. View the logs.


3 days ago

#10 @desrosj
3 days ago

The Dashicons font has been updated in trunk as of Core-48456.

Last time around, the new Dashicons were not added to the resource until after release. I'd be fine adding them before that as long as they are sufficiently flagged as unreleased. But I do think they should be added into the groups they will eventually live.

For the new icons coming from Gutenberg, I think there should be a new "Block editor" section added above TinyMCE for those. The bell icon can go in Notifications, and the rest can probably be placed in Miscellaneous.

This ticket was mentioned in Slack in #design-dashicons by casiepa. View the logs.


3 days ago

Note: See TracTickets for help on using tickets.