WordPress.org

Making WordPress.org

Opened 6 months ago

Closed 2 months ago

Last modified 2 months ago

#5172 closed defect (fixed)

Dashicons: Add missing ones and the upcoming ones for WP 5.5

Reported by: casiepa Owned by: coffee2code
Milestone: Priority: normal
Component: Developer Hub Keywords: has-patch
Cc:

Description

Some issues with the dashicons page on https://developer.wordpress.org/resource/dashicons/

  • A few icons from the current WP version seems to be missing
  • the bbPress icon has the wrong code mentioned
  • the upcoming 5.5 ones are missing (so people do not create pull requests for ones already done)

Change History (17)

This ticket was mentioned in PR #6 on WordPress/wordpress.org by ePascalC.


6 months ago

https://meta.trac.wordpress.org/ticket/5172
Fixed bbPress icon code
Added some missing icons from releases up to WP 5.4
Added the upcoming WP 5.5 dashicons

#2 @casiepa
6 months ago

  • Keywords has-patch added

#3 @dd32
6 months ago

In 9776:

Developer: Include the 'category'/Group of the icons in the glyph preview.

This allows for users to know which group of icons a search result belongs to.

See #5172.

#4 @dd32
6 months ago

In 9777:

Developer: Make r9776 work when selecting the first dashicon in a section.

See #5172.

#5 @dd32
6 months ago

In 9778:

Developer: Dashicons: Correct some dashicons and add the new ones.

Props casiepa.
See https://github.com/WordPress/wordpress.org/pull/6
See #5172.

#6 @dd32
6 months ago

Adding the 5.5+ dashicons will have to wait until Core is updated with the new dashicons, since we use trunk's dashicons.css file.

[9776]/[9777] were intended to allow adding the 5.5+ section and having some kind of note show up in the upper glyph section to indicate that it would only be available in 5.5 when using the search functionality.

#7 @desrosj
4 months ago

Just came across this ticket. It does not appear that Dashicons has been updated for 5.5. I found https://core.trac.wordpress.org/ticket/49913, which lines up time wise and appears to be the update this ticket is referring to, but it was never put into the 5.5 milestone.

As this ticket is an enhancement ticket, a special exception would need to be made as feature requests and enhancements are not allowed after beta 1.

Is this dashicons update essential for 5.5?

This ticket was mentioned in Slack in #design-dashicons by casiepa. View the logs.


4 months ago

This ticket was mentioned in Slack in #design-dashicons by casiepa. View the logs.


3 months ago

#10 @desrosj
3 months ago

The Dashicons font has been updated in trunk as of Core-48456.

Last time around, the new Dashicons were not added to the resource until after release. I'd be fine adding them before that as long as they are sufficiently flagged as unreleased. But I do think they should be added into the groups they will eventually live.

For the new icons coming from Gutenberg, I think there should be a new "Block editor" section added above TinyMCE for those. The bell icon can go in Notifications, and the rest can probably be placed in Miscellaneous.

This ticket was mentioned in Slack in #design-dashicons by casiepa. View the logs.


3 months ago

#12 @coffee2code
2 months ago

  • Owner set to coffee2code
  • Status changed from new to accepted

#13 @coffee2code
2 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 10149:

Developer: Add dashicons introduced in WP 5.5.

  • Adds 2 new sections: Block Editor, Databases
  • Adds 71 new icons

Props casiepa, desrosj, coffee2code.
Fixes #5172.

#14 @coffee2code
2 months ago

@desrosj: Not sure if warrants updating, but the WP 5.5 field guide for the dashicons update missed a few icons.

Missing from field guide for the block editor:

  • dashicons-align-full-width
  • dashicons-align-wide
  • dashicons-button
  • dashicons-ellipsis
  • dashicons-heading

Also, a pair of counts were wrong:

  • field guide mentions 26 block editor icons, lists 27, but there were really 32 (the difference being the 5 listed above).
  • field guide mentions 65 new icons, but I count 71.

#15 @desrosj
2 months ago

Thanks @coffee2code! I updated the post to reflect this.

#17 @coffee2code
2 months ago

In 10186:

Developer: Comment out the Google+ dashicon.

The service is defunct and an identical version of the dashicon was recently added for Google.

See #5172.

Note: See TracTickets for help on using tickets.