Opened 4 years ago

Closed 4 years ago

#5360 closed defect (bug) (fixed)

Prevent broken /support/ links

Reported by: jonoaldersonwp's profile jonoaldersonwp Owned by:
Milestone: Priority: low
Component: International Sites (Rosetta) Keywords: seo


Many Rosetta sites link to a local /support/ URL (typically in the footer, but also from arbitrary in-content locations), but this page frequently doesn't exist and returns a 404.


This is a pretty terrible user experience, and represents many thousands of broken links throughout the ecosystem.

I propose that the best way to fix this would be to:

Whilst it's not ideal to run this kind of logic at this point in the cascade, it means that we can don't need to manage adding/removing redirects if individual locales create dedicated support pages.

Change History (5)

#1 @dd32
4 years ago

Do you have any examples of where things link to non-existent /support/ pages? We output a lot of localised-links and I wanted to make sure the place you're seeing this link isn't generated automatically incorrectly.

Returning a redirect for 404'ing /support/ seems reasonable to me.

#2 follow-up: @jonoaldersonwp
4 years ago


Looks like all footers on plugin and theme pages (and /plugins/ and /themes/).

#3 in reply to: ↑ 2 @dd32
4 years ago

Replying to jonoaldersonwp:


Looks like all footers on plugin and theme pages (and /plugins/ and /themes/).

Awesome, yup, that's a bug.
The footer on those pages should be the same as the homepage links.

The problem here is related to the wacky things we do to make the Themes/Plugins/Gutenberg subsites appear as a site in the Rosetta network too, as a result, the function responsible for finding out if exists incorrectly checks for existing.

I'll get that fixed up so the links are correct, and get a redirect added anyway for ease of use.

#4 @jonoaldersonwp
4 years ago

Nice one! :)

#5 @dd32
4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Redirects in place:

curl -Is | grep ^location

Forums redirects have a double redirect, but it's a convenience-only redirect anyway (It was already partially in place)

$ curl -ILs | grep ^location

Footer links corrected:

$ curl -s | grep -E '<li>.+?/support/'
<li><a href="//" title="Forums, documentation, and other resources">Support</a></li>
<li><a href="//" title="Foren, Dokumentationen und andere Ressourcen">Support</a></li>

(de has forum, de-ch does not)

Note: See TracTickets for help on using tickets.