Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#5431 closed task (blessed) (fixed)

Plugin Directory: Remove unused React code

Reported by: ryelle's profile ryelle Owned by: ryelle's profile ryelle
Milestone: Priority: normal
Component: Plugin Directory Keywords: has-patch


As part of the Plugin Directory theme refresh #1719, the theme UI was rewritten into a React app. It was disabled, and has been unused waiting to be re-enabled. This would need some investment to get it to a launchable state (best practices have changed, packages would need updating, etc). Since development time is better spent on other features, this code should be removed.

Change History (3)

This ticket was mentioned in PR #19 on WordPress/ by ryelle.

4 years ago

Remove the react theme code, leaving only the screenshot component (the only part of the app currently in use). This leaves most of the CSS in place, but collapses it down into fewer folders. This also updates the build process to use wp-scripts for the JS, so we can get the dependency extraction code.

npm run build or npm run watch can be used to build the CSS and JS.

#2 @ryelle
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 10605:

Plugin Directory: Remove unused React code.

As part of the Plugin Directory refresh #1719, the UI was rewritten into a React app, but currently only the screenshot slider uses React. This removes all the React JS except for the screenshots, and flattens the Sass into less complex files. Additionally it updates the packages and JS build process to use @wordpress/scripts.

Fixes #5431.

ryelle commented on PR #19:

3 years ago

Committed in r10605.

Note: See TracTickets for help on using tickets.