WordPress.org

Making WordPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#585 closed enhancement (fixed)

exclude unconfirmed tickets/attendees from the attendees list

Reported by: nvwd Owned by:
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: has-patch
Cc:

Description

when processing the attendees shortcode, do not display unconfirmed tickets

Attachments (1)

585.patch (765 bytes) - added by nvwd 5 years ago.

Download all attachments as: .zip

Change History (7)

@nvwd
5 years ago

This ticket was mentioned in IRC in #wordpress-meta by NowellVanHoesen. View the logs.


5 years ago

#2 @iandunn
5 years ago

This was requested by Jen and Andrea during the Community Team meeting last week.

#3 @iandunn
5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

This was committed in 59d8c35. While reviewing your patch I realized the changes would need to be made in the require-login addon, to avoid affecting sites that don't have the addon enabled, and also that filtering the get_posts() parameters would be more efficient than fetching each attendee's post meta, so I made those changes.

#4 @nvwd
5 years ago

@iandunn,

My first thought was to add to the existing meta query, but wasn't sure how it would effect performance.

Login addon sounds like a better fit also.

#5 @iandunn
5 years ago

hmm, I didn't do any benchmarks, but I would think that the cost of a single postmeta join during get_posts() would be much cheaper than n get_post_meta() calls, especially when n can be 1,000 or more. I'm happy to be corrected, though :)

#6 @nvwd
5 years ago

I have no clue. Can always roll with what is there and test performance later.

Note: See TracTickets for help on using tickets.