Making WordPress.org

Opened 3 years ago

Closed 18 hours ago

#6003 closed defect (bug) (wontfix)

W3C CSS syntax for pseudo element in meta

Reported by: multidots1896's profile multidots1896 Owned by:
Milestone: Priority: lowest
Component: buddypress.org Keywords: has-patch commit
Cc:

Description

I have checking in meta sites, and moving in buddypress.org in that bb-base theme has found a pseudo element structure in style.css file.
on their for pseudo element like :after and :before single-colon syntax was used but this type of syntax was used in CSS1 and CSS2.
In latest CSS3 level we used double colon notation for pseudo element (::after and ::before).

Attachments (1)

6003.patch (5.4 KB) - added by multidots1896 3 years ago.
added patch for this ticket where i modify css

Download all attachments as: .zip

Change History (3)

@multidots1896
3 years ago

added patch for this ticket where i modify css

#1 @dd32
3 years ago

  • Keywords commit added
  • Priority changed from high to lowest

This isn't the only case where single-colons are used, https://css-tricks.com/to-double-colon-or-not-do-double-colon/ is a good article about it - put simply, it doesn't matter if it's single or double really.

Since the work is done, no harm in committing it though.

#2 @coffee2code
18 hours ago

  • Resolution set to wontfix
  • Status changed from new to closed

Thanks for the patch! Recently all BuddyPress site theme-related tickets on the BuddyPres Trac have been closed by the BuddyPress team per the theme redesign via BP#9193 that is in progress. Since this is a very minor change (that could otherwise be committed) and the theme will be completely rewritten, I'm going to close this as 'wontfix'. If the new theme does not adhere to the syntax recommended here, then feel free to open a ticket on the BuddyPress Trac at that time.

Note: See TracTickets for help on using tickets.