Making WordPress.org

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#6291 closed defect (bug) (fixed)

Profile images need ALT attributes on Trac tickets

Reported by: sabernhardt's profile sabernhardt Owned by: dd32's profile dd32
Milestone: Priority: normal
Component: Trac Keywords: has-patch
Cc:

Description

Accessibility: images are missing alt attributes.

  1. The Reporter and Owner images are also linked, so their alternative text should describe the link destination. To differentiate each of these links from its next link (to other tickets that the reporter has opened or that the owner owns), this text could include "profile" after the username.
  2. For each comment, the profile image is part of the text link. Therefore, it does not need alternative text, but it still needs an empty alt attribute.
  3. The Slack/IRC notifications could have empty alt attributes for their images as well. Alternative text like "chat discussion" might add some value, yet these images are mainly decorative.

Change History (6)

This ticket was mentioned in PR #70 on WordPress/wordpress.org by sabernhardt.


2 years ago
#1

  • Keywords has-patch added
  • Add alt="[username] profile" for Reporter and Owner profile images.
  • Add empty alt="" attribute for commenters' profile images and Slack/IRC notifications.

https://meta.trac.wordpress.org/ticket/6291

#2 @dd32
2 years ago

  • Owner set to dd32
  • Status changed from new to reviewing

Thanks @sabernhardt This seems like a reasonable change, and the PR is appreciated!

#3 @dd32
2 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 11795:

Trac: Set appropriate alt tags for avatars.

Props sabernhardt.
Fixes #6291.
Closes https://github.com/WordPress/wordpress.org/pull/70.

#4 @dd32
2 years ago

Just noting, that perhaps alt="${wporg_user}'s profile" would've been better, as now I'm looking at it on trac.w.org, alt="dd32 profile" isn't exactly good phrasing.

#5 @sabernhardt
2 years ago

Yes, including the apostrophe+S should be better than what I had. Thanks!

#6 @dd32
2 years ago

In 11797:

Trac: Change it from "dd32 profile" to "dd32's profile".

Amends [11795].
See #6291.

Note: See TracTickets for help on using tickets.