Making WordPress.org

Opened 3 years ago

Closed 2 years ago

#6339 closed defect (bug) (reported-upstream)

learn.wordpress.org top leave menu hover issue

Reported by: praful2111's profile praful2111 Owned by:
Milestone: Priority: normal
Component: Global Header/Footer Keywords:
Cc:

Description

Learn WordPress has a text-decoration issue on the top header menu part.

screenshot : https://prnt.sc/jT7cjX7fK0e8

Change History (4)

#1 @praful2111
3 years ago

CSS to fix this issue.

.wp-block-navigation:where(:not([class*=has-text-decoration])) a:active, .wp-block-navigation:where(:not([class*=has-text-decoration])) a:focus {
    text-decoration: none;
}

#2 @dd32
3 years ago

It looks like this is coming from the Learn theme, which is overriding a:hover.

But also it's coming from Gutenberg, because it's menu seems to only remove text-underline on a rather than also adding the a:hover/etc variants. I think this needs to be filed upstream with Gutenberg as well.

We also have a handful of styles in the Header CSS that we could add this to, https://github.com/WordPress/wporg-mu-plugins/labels/Header%20%26%20Footer

#3 @praful2111
3 years ago

@dd32 As I check other sites have below CSS to remove the top menu text decoration.

.wp-block-navigation:where(:not([class*=has-text-decoration])) a:active, .wp-block-navigation:where(:not([class*=has-text-decoration])) a:focus {
    text-decoration: none;
}

So I hope above code will fix issue for learn site.

#4 @ryelle
2 years ago

  • Resolution set to reported-upstream
  • Status changed from new to closed

This was also reported at https://github.com/WordPress/wporg-mu-plugins/issues/206, closing in favor of that issue.

Note: See TracTickets for help on using tickets.