Making WordPress.org

Opened 21 months ago

Last modified 3 weeks ago

#6507 new enhancement

Add "Changes Requested" sections to Trac reports

Reported by: desrosj's profile desrosj Owned by:
Milestone: Priority: normal
Component: Trac Keywords:
Cc:

Description (last modified by SergeyBiryukov)

Recently, a changes-requested keyword was introduced in Core Trac.

We should update the reports that are workflow oriented to include a section for this new workflow state:

There's likely a few more.

Discussion related to adding the keyword: https://wordpress.slack.com/archives/C18723MQ8/p1650951302813149. Added in [r11798].

Attachments (1)

6507.png (78.8 KB) - added by SergeyBiryukov 3 weeks ago.

Download all attachments as: .zip

Change History (3)

#1 @desrosj
21 months ago

There should also be a report added for this keyword, like there is for needs-patch needs-unit-tests, etc.

@SergeyBiryukov
3 weeks ago

#2 in reply to: ↑ description @SergeyBiryukov
3 weeks ago

  • Description modified (diff)

Replying to desrosj:

Recently, a changes-requested keyword was introduced in Core Trac.

We should update the reports that are workflow oriented to include a section for this new workflow state:

This is now addressed for the reports mentioned.

Started looking into this after noticing that tickets on these reports have not been ordered correctly for a while, and ticket groups were displayed multiple times with different tickets, instead of being combined in a single location, see an example on the screenshot.

After some investigation, the SQL conditionals at the top of the report query need to match the ones at the bottom, e.g.

SELECT CASE 
  WHEN keywords LIKE '%fixed_major%'
  THEN 'Needs Merging from Trunk'
  WHEN ( keywords LIKE '%dev_reviewed%' AND keywords LIKE '%commit%' )
  THEN 'Commit Candidates with Dev Review'
  WHEN ( keywords LIKE '%dev_feedback%' AND keywords LIKE '%commit%' )
  THEN 'Commit Candidates which need Dev Review'
  ...

should correspond to:

ORDER BY CASE
  WHEN keywords LIKE '%fixed_major%'
  THEN 0
  WHEN ( keywords LIKE '%dev_reviewed%' AND keywords LIKE '%commit%' )
  THEN 1
  WHEN ( keywords LIKE '%dev_feedback%' AND keywords LIKE '%commit%' )
  THEN 2
  ...

There were some discrepancies, specifically WHEN keywords LIKE '%changes_requested%' was missing at the bottom. This is also resolved now.

Note: See TracTickets for help on using tickets.