Making WordPress.org

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#664 closed defect (fixed)

The credits API endpoint doesn't return validators

Reported by: petya Owned by: nacin
Milestone: Priority: high
Component: API Keywords: has-patch commit


A comment posted on Polyglots earlier today got me digging to find the tr_TR validators and the Translators handbook led me to this page on Central: http://wpcentral.io/internationalization.

None of the team pages list any validators, there's only a list of translators - https://cloudup.com/cYIrwyjl_vL

Bottom line is if you're looking for your local validator for any language, you won't be able to find them.

I thought the translators list just showed the validators, but when I double checked, there happened to be new users with zero activity, active forum moderators with no validator rights and active validators in the list of translators in the bg_BG translators list - http://wpcentral.io/internationalization/bg/.

Attachments (1)

664.diff (1.1 KB) - added by markoheijnen 7 years ago.

Download all attachments as: .zip

Change History (8)

#1 @markoheijnen
7 years ago

  • Cc info@… added

I looked into why validators didn't show up and I see that the API doesn't return them. See https://api.wordpress.org/core/credits/1.1/?version=4.0&locale=nl_NL.

#2 @markoheijnen
7 years ago

  • Component changed from translate.wordpress.org to api.wordpress.org
  • Priority changed from normal to high
  • Summary changed from Team pages on http://wpcentral.io/internationalization don't show any validators to The credits API endpoint doesn't return validators

Changing the summary, priority and component since it's a bug on the API side. Reason of the higher priority is because the validators also don't show up on the credit page.

This ticket was mentioned in IRC in #wordpress-meta by markoheijnen. View the logs.

7 years ago

7 years ago

#4 @markoheijnen
7 years ago

Added a patch which may or may not work. I checked [909] and this patch seems it should do the job.

#5 @SergeyBiryukov
7 years ago

  • Keywords has-patch commit added

Looking at [909], 664.diff definitely makes sense.

#6 @nacin
7 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 924:

Credits: Use new table prefix.

props markoheijnen.
fixes #664.

#7 @nacin
7 years ago

In 926:

Credits: Proper fix for #664. The tables are in separate databases, can't join them. The path restriction is because team P2s do/will exist. see #664.

Note: See TracTickets for help on using tickets.