Making WordPress.org

Opened 16 months ago

Closed 3 months ago

#6867 closed defect (bug) (fixed)

Increase minimum font size to 12px with default browser settings

Reported by: oglekler's profile oglekler Owned by: coffee2code's profile coffee2code
Milestone: Priority: normal
Component: Make (Get Involved) / P2 Keywords: good-first-bug has-patch needs-testing reporter-feedback has-testing-info
Cc:

Description

Example:
https://make.wordpress.org/meetings/
on this page in Chrome and in Firefox as well, I have font size for numeric representation of days in 8px. I believe that I don't have significant problems with vision, but for me, they are uncomfortably small, I need to lean to my screen.

Somehow Google PageSpeed thinks that font-size check isn't applicable to this page and Lightbox didn't flagged it either, still we have this small size issue.

Attachments (2)

2023-03-19_20-24-51.png (52.7 KB) - added by oglekler 16 months ago.
6867.diff (297 bytes) - added by prashantbhivsane 15 months ago.
Setting font size to 1.2em

Download all attachments as: .zip

Change History (12)

#1 @tellyworth
16 months ago

  • Keywords good-first-bug added

@prashantbhivsane
15 months ago

Setting font size to 1.2em

#2 @prashantbhivsane
15 months ago

  • Keywords has-patch needs-testing added

#3 @prashantbhivsane
15 months ago

@tellyworth @oglekler Can this be assigned to me?

Last edited 15 months ago by prashantbhivsane (previous) (diff)

#4 @dd32
15 months ago

It looks like this issue is within this plugin, and a PR should be filed there: https://github.com/WordPress/meeting-calendar

#5 @prashantbhivsane
15 months ago

Last edited 15 months ago by prashantbhivsane (previous) (diff)

#6 @prashantbhivsane
14 months ago

  • Keywords reporter-feedback added

#7 @akmelias
14 months ago

Hey, I am at WCSylhet Contributors Day, reviewing good-first-bug tickets. The code seems to be alright. Well done @prashantbhivsane

#8 @prashantbhivsane
14 months ago

hi @dd32 , any further action needed from me for this ticket?

#9 @devmuhib
4 months ago

  • Keywords has-testing-info added

Test Report

I checked the pull request made by @prashantbhivsane. I applied the styles he added on PR and it's working.

Actual Results

  • ✅ Issue resolved with PR.

Additional Notes

  • Any additional details worth mention.

Supplemental Artifacts

Before Applying Patch:
https://i.imgur.com/2y87XVJ.jpg
After Applying Patch:
https://i.imgur.com/YwGPEr6.jpeg

#10 @coffee2code
3 months ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 13679:

Make home theme: Increase font size for calendar days numbering.

This was more appropriately reported upstream to the Meeting Calendar plugin, but no action has been taken yet: https://github.com/WordPress/meeting-calendar/pull/149

Props prashantbhivsane, oglekler, akmelias, devmuhib.
Fixes #6867.

Note: See TracTickets for help on using tickets.