Search not returning obvious matches

[topher1kenobe]

This search: ​https://wordpress.org/photos/?s=peanut+butter

does not return this image: ​https://wordpress.org/photos/photo/642642c1de/

despite the search terms being exactly represented in the alt text.

[Otto42]

This comes from the limit_partial_matching function. I'm not entirely certain what the purpose of this regular expression is, but something about it doesn't look right.

https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/search.php#L95

[Otto42]

Related: https://meta.trac.wordpress.org/ticket/6569

[Otto42]

The relevant portion of the SQL:

OR (post_content LIKE 'peanut%') ...
OR (post_content LIKE 'butter%') ...

And so on. Basically, it will only match peanut or butter at the start of the content. Probably not what was intended, so it's unlikely that that fix worked.

[Otto42]

In 12543:

Photo directory: Switch limit matching to use a regular expression for the query. The extra backslashes are because of the ridiculous escaping necessary for both PHP and mySQL. Fixes #6934. Related #6569