core.trac comments getting the same comment number, messing up edits and permalinks

[boonebgorges]

I posted a new comment on ​https://core.trac.wordpress.org/ticket/5809. Comment appeared correctly. I went to edit it, and it opened two separate comments for editing - the proper one near the bottom of the page, as well as one higher up by wonderboymusic. The edit itself only ended up applying to the first of those (not surprisingly, I guess, if they internally share a comment_id).

[SergeyBiryukov]

This was an issue in older Trac versions: ​#WP18767. Should be fixed for new tickets, but still exists for old ones.

[nacin]

Correct. This is an old issue. It only affects two open tickets: ​#WP5809 (affected heavily) and ​#WP20683 (only affects comments 5 and 6).

per: select distinct ticket from ticket_change where field = 'comment' and oldvalue <> '' and ticket in (select id from ticket where status <> 'closed') group by ticket, oldvalue having count(*) > 1

[nacin]

I've fixed the numbering in ​#WP20683 and ​#WP5809.

[boonebgorges]

It's a Christmas miracle!