Making WordPress.org

Opened 4 months ago

Closed 4 months ago

Last modified 4 months ago

#7192 closed defect (bug) (fixed)

Images on the WordPress Planet site are not being displayed due to the absence of the URL attribute.

Reported by: utsav72640's profile utsav72640 Owned by:
Milestone: Priority: lowest
Component: WordPress.org Site Keywords:
Cc:

Description

Images on the WordPress Planet site are not being displayed, Can you please check attached video URL, https://www.awesomescreenshot.com/video/19804007?key=10d92d240f7c6f2528de3c4cd166b594

Change History (10)

#1 in reply to: ↑ description @utsav72640
4 months ago

Check this URL, https://planet.wordpress.org/

Replying to utsav72640:

Images on the WordPress Planet site are not being displayed, Can you please check attached video URL, https://www.awesomescreenshot.com/video/19804007?key=10d92d240f7c6f2528de3c4cd166b594

This ticket was mentioned in Slack in #meta by utsav72640. View the logs.


4 months ago

#3 @Otto42
4 months ago

  • Component changed from HelpHub to WordPress.org Site

#4 @dd32
4 months ago

  • Keywords needs-testing needs-screenshots removed
  • Owner set to dd32
  • Status changed from new to accepted

#5 follow-up: @dd32
4 months ago

  • Owner dd32 deleted
  • Priority changed from normal to lowest
  • Status changed from accepted to assigned

This appears to be an issue in the planet python app, it looks like it's choking on the large <img generated by current WordPress versions.

Eg, <img /> for a tavern article is generated from this:

<img decoding="async" fetchpriority="high" width="1856" height="388" data-attachment-id="147652" data-permalink="https://wptavern.com/wordpress-plugin-review-team-addresses-backlog-of-900-plugins-implements-strategies-to-improve-approval-process/screen-shot-2023-08-09-at-5-24-43-pm" data-orig-file="https://149611589.v2.pressablecdn.com/wp-content/uploads/2023/08/Screen-Shot-2023-08-09-at-5.24.43-PM.png" data-orig-size="1856,388" data-comments-opened="0" data-image-meta="{&quot;aperture&quot;:&quot;0&quot;,&quot;credit&quot;:&quot;&quot;,&quot;camera&quot;:&quot;&quot;,&quot;caption&quot;:&quot;&quot;,&quot;created_timestamp&quot;:&quot;0&quot;,&quot;copyright&quot;:&quot;&quot;,&quot;focal_length&quot;:&quot;0&quot;,&quot;iso&quot;:&quot;0&quot;,&quot;shutter_speed&quot;:&quot;0&quot;,&quot;title&quot;:&quot;&quot;,&quot;orientation&quot;:&quot;0&quot;}" data-image-title="Screen-Shot-2023-08-09-at-5.24.43-PM" data-image-description="" data-image-caption="" data-medium-file="https://149611589.v2.pressablecdn.com/wp-content/uploads/2023/08/Screen-Shot-2023-08-09-at-5.24.43-PM-300x63.png" data-large-file="https://149611589.v2.pressablecdn.com/wp-content/uploads/2023/08/Screen-Shot-2023-08-09-at-5.24.43-PM-500x105.png" src="https://149611589.v2.pressablecdn.com/wp-content/uploads/2023/08/Screen-Shot-2023-08-09-at-5.24.43-PM.png" alt="" class="wp-image-147652" srcset="https://149611589.v2.pressablecdn.com/wp-content/uploads/2023/08/Screen-Shot-2023-08-09-at-5.24.43-PM.png 1856w , https://149611589.v2.pressablecdn.com/wp-content/uploads/2023/08/Screen-Shot-2023-08-09-at-5.24.43-PM-300x63.png 300w , https://149611589.v2.pressablecdn.com/wp-content/uploads/2023/08/Screen-Shot-2023-08-09-at-5.24.43-PM-500x105.png 500w , https://149611589.v2.pressablecdn.com/wp-content/uploads/2023/08/Screen-Shot-2023-08-09-at-5.24.43-PM-768x161.png 768w , https://149611589.v2.pressablecdn.com/wp-content/uploads/2023/08/Screen-Shot-2023-08-09-at-5.24.43-PM-1536x321.png 1536w " sizes="(max-width: 1856px) 100vw, 1856px" />

The most recent code I can locate for the app is this: https://github.com/python/planet/tree/master/code (9-14 years old) as the website is down. Looking closer, that's probably the canonical source for the code, and I think we might be running an older version than that.

Marking this as lowest-priority and unassigning myself, as this probably requires far more delving into python than I have time for today.

#6 @utsav72640
4 months ago

Hello @dd32

Thanks for the update,

if you have recently updated any new content or images, the images may not be displayed properly.

Can you please check latest screenshot, https://tinyurl.com/25jjambk

#7 @dd32
4 months ago

@utsav72640 Yes, this is broken. As I said.

#8 in reply to: ↑ 5 @dd32
4 months ago

Replying to dd32:

This appears to be an issue in the planet python app, it looks like it's choking on the large <img generated by current WordPress versions.

Eg, <img /> for a tavern article is generated from this:

<img decoding="async" fetchpriority="high" width="1856" height="388" ...  data-image-meta="{&quot;aperture&quot;:&quot;0&quot;,&quot;credit&quot;:&quot;&quot;,&quot;camera&quot;:&quot;&quot;,&quot;caption&quot;:&quot;&quot;,&quot;created_timestamp&quot;:&quot;0&quot;,&quot;copyright&quot;:&quot;&quot;,&quot;focal_length&quot;:&quot;0&quot;,&quot;iso&quot;:&quot;0&quot;,&quot;shutter_speed&quot;:&quot;0&quot;,&quot;title&quot;:&quot;&quot;,&quot;orientation&quot;:&quot;0&quot;}" data-image-title="Screen-Shot-2023-08-09-at-5.24.43-PM" data-image-description="" data-image-caption="" data-medium-file="https://149611589.v2.pressablecdn.com/wp-content/uploads/2023/08/Screen-Shot-2023-08-09-at-5.24.43-PM-300x63.png" data-large-file="https://149611589.v2.pressablecdn.com/wp-content/uploads/2023/08/Screen-Shot-2023-08-09-at-5.24.43-PM-500x105.png" src="https://149611589.v2.pressablecdn.com/wp-content/uploads/2023/08/Screen-Shot-2023-08-09-at-5.24.43-PM.png" alt="" class="wp-image-147652" srcset="https://149611589.v2.pressablecdn.com/wp-content/uploads/2023/08/Screen-Shot-2023-08-09-at-5.24.43-PM.png 1856w , https://149611589.v2.pressablecdn.com/wp-content/uploads/2023/08/Screen-Shot-2023-08-09-at-5.24.43-PM-300x63.png 300w , https://149611589.v2.pressablecdn.com/wp-content/uploads/2023/08/Screen-Shot-2023-08-09-at-5.24.43-PM-500x105.png 500w , https://149611589.v2.pressablecdn.com/wp-content/uploads/2023/08/Screen-Shot-2023-08-09-at-5.24.43-PM-768x161.png 768w , https://149611589.v2.pressablecdn.com/wp-content/uploads/2023/08/Screen-Shot-2023-08-09-at-5.24.43-PM-1536x321.png 1536w " sizes="(max-width: 1856px) 100vw, 1856px" />

Ended up doing some digging.. Something is broken in it's HTML parsing/sanitizing. Thankfully it errs on the side of caution when it encounters issues and returns the known-good data.

It parsed that as:

<img decoding="async" fetchpriority="high" width="1856" height="388" ... data-image-meta="{" aperture />

Ultimately generating this, with the only valid attributes:

<img width="1856" height="388" />

I'm going to make a minor adjustment and see if it resolves it, probably won't take effect until an affected feed makes a new post.

#9 @dd32
4 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

I'm going to make a minor adjustment and see if it resolves it, probably won't take effect until an affected feed makes a new post.

This did work.

Because of the age of the code, I simply hacked in a regex replace and striped out data-* HTML attributes from the feeds.. such that the Planet RSS parser didn't fail.

Last edited 4 months ago by dd32 (previous) (diff)

#10 @utsav72640
4 months ago

Thanks @dd32

Note: See TracTickets for help on using tickets.