Making WordPress.org

Opened 4 months ago

Closed 4 months ago

Last modified 2 months ago

#7793 closed defect (bug) (fixed)

Make the new w.org login checkbox translatable

Reported by: audrasjb's profile audrasjb Owned by: dd32's profile dd32
Milestone: Priority: high
Component: Login & Authentication Keywords:
Cc:

Description (last modified by dd32)

The new "WP Engine affiliation" checkbox is not translatable, which leads to an accessibility issue for people not using the EN_us locale.

I didn't found it on WordPress.org Github repository so couldn't make a PR for this.

Change History (9)

#1 @audrasjb
4 months ago

Note for everyone: please do not use this ticket for further discussion about this checkbox. This ticket is only about making it translatable.

#2 follow-up: @dd32
4 months ago

  • Description modified (diff)

Removed reference to a commit from me, that while related, is not the checkbox.

#3 in reply to: ↑ 2 ; follow-up: @mattbeck
4 months ago

Replying to dd32:

Removed reference to a commit from me, that while related, is not the checkbox.

Purely out of curiosity, as I can't find the actual change anywhere, but the do_action calls that were added suggest how the change could have gotten in.

Did someone just hack the change into a functions file directly instead of committing it?

#4 in reply to: ↑ 3 ; follow-up: @dd32
4 months ago

Replying to mattbeck:

Did someone just hack the change into a functions file directly instead of committing it?

The WordPress.org codebase is a combination of private and public repositories, not everything is open-source. The checkbox, and enforcement of it, is added via a private plugin, there's no 'hacking' of the deployed code or replacement/alteration of the core WP files.

The hooks added were left out of the public theme that I had built (which uses the same design, and html structure as wp-login.php), and match it up with the actions that were already firing when you visited /wp-login.php directly.

#5 in reply to: ↑ 4 @mattbeck
4 months ago

Replying to dd32:

Replying to mattbeck:

Did someone just hack the change into a functions file directly instead of committing it?

The WordPress.org codebase is a combination of private and public repositories, not everything is open-source. The checkbox, and enforcement of it, is added via a private plugin, there's no 'hacking' of the deployed code or replacement/alteration of the core WP files.

The hooks added were left out of the public theme that I had built (which uses the same design, and html structure as wp-login.php), and match it up with the actions that were already firing when you visited /wp-login.php directly.

Appreciate the explanation, makes sense. Thanks.

#6 @foosantos
4 months ago

Yes, it would be fantastic if we could translate it into other languages!

#7 @audrasjb
4 months ago

Hello, is it possible to get this fixed somehow?
Translation issues are also accessibility and inclusivity issues.
Since that change is at the first place not super great for the WordPress community, it would be nice to at least conform ourselves to our very own WCAG compliance commitments. Thanks!

#8 @dd32
4 months ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 14144:

Login: Add a file which contains strings which are used on login.wordpress.org (and related areas) which are not otherwise available in GlotPress.

Fixes #7793.

edit: Confirmed it's in GlotPress: https://wordpress.slack.com/archives/C02RP50LK/p1729825318263879

Last edited 4 months ago by dd32 (previous) (diff)

#9 @dd32
2 months ago

In 14279:

Login: Update string list.

See #7793.

Note: See TracTickets for help on using tickets.