Making WordPress.org

Opened 14 months ago

Closed 12 months ago

Last modified 7 months ago

#7804 closed defect (bug) (fixed)

Button Misalignment in Pull Request Section on Core Trac

Reported by: parthvataliya's profile parthvataliya Owned by: dd32's profile dd32
Milestone: Priority: normal
Component: Trac Keywords:
Cc:

Description

In the Core Trac site's pull request section, when the pull request title and username are lengthy, the "View patch" and "View PR" buttons are misaligned. This breaks the structure and affects the overall user interface.

Steps to reproduce:

  1. Navigate to the pull request section in Core Trac.
  2. View a PR with a long title and/or username.
  3. Observe the misalignment of the buttons.

Expected behavior: The "View patch" and "View PR" buttons should remain properly aligned in the same row, regardless of the length of the PR title or username.

Attachments (1)

Screenshot from 2024-10-15 15-38-45.png (37.8 KB) - added by parthvataliya 14 months ago.
As shown in the screenshot, the buttons are not staying within the same row, which could negatively impact user experience, especially for users viewing detailed PRs with longer titles or usernames.

Download all attachments as: .zip

Change History (4)

@parthvataliya
14 months ago

As shown in the screenshot, the buttons are not staying within the same row, which could negatively impact user experience, especially for users viewing detailed PRs with longer titles or usernames.

#1 @dd32
12 months ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 14251:

Trac: Better visual style for GitHub PRs when the content wraps.

H/t parthvataliya.
Fixes #7804.

#2 @coffee2code
7 months ago

Noting for future reference that the Core Trac ticket from the associated screenshot is https://core.trac.wordpress.org/ticket/59960.

While this could happen with any row field being long, I feel that this is mostly due (at least for this ticket) to the third column being long (with "✅ Unknown, Approved" as it had at the time of the screenshot, or "✅ All checks pass, Approved" as it does now).

#3 @coffee2code
7 months ago

In 14442:

Trac: Prevent nowrap from applying to message in "Pull Request" section when there are no pull requests to list.

Ensures nowrap style only applies if there is more than one div present, which would only be the case if a PR was being shown.

Props truptikanzariya. gulamdastgir04, coffee2code.
Fixes #7919.
See #7804.

Note: See TracTickets for help on using tickets.