WordPress.org
Get WordPress

Making WordPress.org

Opened 6 months ago

Closed 6 months ago

#8046 closed defect (bug) (invalid)

Github PR are not being detected as patches In Trac

Reported by: sirlouen's profile SirLouen Owned by:
Milestone: Priority: normal
Component: Trac Keywords:
Cc:

Description

In the reports, Tickets with GH PRs are not detected as tickets with patches.

​Example

https://i.imgur.com/WIS8rJC.png

Change History (3)

#1 @dd32
6 months ago

  • Resolution set to invalid
  • Status changed from new to closed

Trac reports are based on Keywords. GitHub PRs are only integrated with tickets via Comments + Keywords.

You've removed the has-patch keyword, which means it doesn't have a patch in reports.

Keywords needs-patch added; has-patch removed

Instead of removing the has-patch keyword, you should be changing it to has-patch changes-requested or has-patch needs-refresh as appropriate.

#2 @SirLouen
6 months ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

@dd32 the has-patch thing is irrelevant
Check this:

https://i.imgur.com/tQRc96I.png

Report: ​https://core.trac.wordpress.org/component/Mail

#3 @SirLouen
6 months ago

  • Resolution set to invalid
  • Status changed from reopened to closed

Ok, I've found the culprit
The only thing that changes to "Ticket with Patches" is the fact that it has-patch + Milestone is not Awaiting Review at the same time.
Same for other keywords.

While it's on Awaiting Review it can only be moved into "Candidates for Closure". And this brings to another issue: #8047

Note: See TracTickets for help on using tickets.