Replace 'Favorite' for unselected favorite plugins to 'Make favorite'

[TomasM]

Recently I wanted to mark a plugin in my profile as 'Favorite', I went to plugin's WP.org section and saw the red heart and red-colored word 'Favorite', right, I thought, probably I made it favorite some time ago...

But somehow I decided to click it and I was surprised that it changed to a strange 'Favorited' :-/

I would suggest to make whole text and heart symbol grey color if plugin is not selected and change the text to 'Make favorite', otherwise it is very misleading.

[TomasM]

Correction, text 'Favorite' is not red, but in any case red heart and the meaning of 'Favorite' creates big confusion.

[samuelsidler]

Currently, the theme directory just has a heart, without any text. There's also #865, which would change this UI a bit. I don't think it makes sense to change the text to "Make favorite" though.

There's probably a better way to design our favorite UI, across both the theme and plugin directory. We should evaluate what other sites do, pick the right one, and make it consistent across both directories.

[samuelsidler]

The new directory will have a heart icon, just like the theme directory. (The code is mostly ready, but needs some UI work.) Closing this as wontfix in favor of no text.

Thanks for the report!