Making WordPress.org

Opened 6 weeks ago

Closed 6 weeks ago

Last modified 6 weeks ago

#8122 closed defect (bug) (fixed)

Upload Twemoji 17.0.1 assets to the CDN

Reported by: desrosj's profile desrosj Owned by:
Milestone: Priority: normal
Component: General Keywords:
Cc:

Description

Twemoji 17.0.1 has been released to include support for Emoji 17.

In order to allow for WordPress Core to update the software, could the assets directory in the zip file be uploaded to the CDN at the URLs

Related #Core64184

Change History (4)

#1 @dd32
6 weeks ago

  • Resolution set to fixed
  • Status changed from new to closed

This has been deployed.

https://s.w.org/images/core/emoji/17.0.1-1/72x72/1fa8a.png

Last edited 6 weeks ago by dd32 (previous) (diff)

#2 follow-up: @desrosj
6 weeks ago

While setting up the PR to make this change in wordpress-develop, I accidentally requested one of the image assets before it was available. This resulted in a cached 404 request. Since the CDN is treated as infinite, this could potentially cause issues, I asked @dd32 to rename the folder.

The assets now live at the following:

#3 in reply to: ↑ 2 @westonruter
6 weeks ago

Replying to desrosj:

While setting up the PR to make this change in wordpress-develop, I accidentally requested one of the image assets before it was available. This resulted in a cached 404 request. Since the CDN is treated as infinite, this could potentially cause issues, I asked @dd32 to rename the folder.

What if someone malicious were to now make a bunch of bogus requests to some anticipated 17.0.2 version which don't currently exist. Would that have the effect of breaking emoji image URLs for future releases, unknown to us?

I'm surprised the 404 responses are cached indefinitely.

#4 @desrosj
6 weeks ago

I am actually very surprised that this has not come up before as well.

My understanding is that purging the cache required the cache for the entire s.w.org cache needs to be purged. Ideally the cache gets flushed for all paths being deployed, but I can't speak to how it's set up or what's possible.

Note: See TracTickets for help on using tickets.