Opened 9 years ago

Closed 9 years ago

#950 closed task (blessed) (fixed)

Update theme modal

Reported by: obenland's profile obenland Owned by: obenland's profile obenland
Milestone: Priority: normal
Component: Theme Directory Keywords:


The theme modal should look more like it's server-side counterpart. In this effort we could also combine CSS files and switch rating stars to use dash icons.

Attachments (1)

theme-repo-page-v2.png (896.5 KB) - added by melchoyce 9 years ago.

Download all attachments as: .zip

Change History (10)

#1 @obenland
9 years ago

  • Owner set to obenland
  • Status changed from new to accepted

#2 @obenland
9 years ago

@melchoyce, I have the modal-as-a-page working locally. One thing that concerns me a little is that the navigation is at the bottom of the page, which on small screens can be confusing.

This ticket was mentioned in Slack in #themereview by obenland. View the logs.

9 years ago

#4 @melchoyce
9 years ago

What if we did something like theme-repo-page-v2.png?

#5 @obenland
9 years ago

Looking good, thanks. Let me see how I can make that work.

#6 @obenland
9 years ago

In 1409: Themes: Design parity between modal and singular theme page.

  • Uses Dashicons to display rating stars.
  • Removes the dependency on admin themes styles.

See #950.

#7 @obenland
9 years ago

In 1410: Themes: Retinize images where possible.

See #950.

#8 @obenland
9 years ago

In 1411: Themes: Explicitly remove margins from close button for Safari.

Fixes a visual bug where the theme navigation bar was higher than the buttons.

See #950.

#9 @obenland
9 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed
Note: See TracTickets for help on using tickets.