Changeset 12175 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-status-transitions.php

Timestamp:

11/01/2022 05:41:04 AM (2 years ago)

Author:

dd32

Message:

Plugin Directory: Don't delete submitted ZIP files immediately upon approval/rejection, and instead delete them x days afterwards.

This provides some room for re-reviewing recently-rejected or recently-approved plugins when required.

Closes ​https://github.com/WordPress/wordpress.org/pull/106.
Fixes #5636.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-status-transitions.php (modified) (4 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-status-transitions.php

@@ -203 +203 @@
      */
     public function approved( $post_id, $post ) {
-        $attachments   = get_attached_media( 'application/zip', $post_id );
         $plugin_author = get_user_by( 'id', $post->post_author );
 
@@ -214 +213 @@
         /*
          Temporarily disable SVN prefill from ZIP files
+        $attachments = get_attached_media( 'application/zip', $post_id );
         if ( $attachments ) {
             $attachment = end( $attachments );
@@ -229 +229 @@
         SVN::import( $dir, 'http://plugins.svn.wordpress.org/' . $post->post_name, sprintf( 'Adding %1$s by %2$s.', $post->post_title, $plugin_author->user_login ) );
 
-        // Delete zips.
-        foreach ( $attachments as $attachment ) {
-            wp_delete_attachment( $attachment->ID, true );
-        }
-
         // Grant commit access.
         Tools::grant_plugin_committer( $post->post_name, $plugin_author );
@@ -255 +250 @@
         $original_permalink = $post->post_name;
         $submission_date    = get_the_modified_date( 'F j, Y', $post_id );
-
-        // Delete zips.
-        foreach ( get_attached_media( 'application/zip', $post_id ) as $attachment ) {
-            wp_delete_attachment( $attachment->ID, true );
-        }
 
         // Change slug to 'rejected-plugin-name-rejected' to free up 'plugin-name'.