Changeset 1871

Timestamp:

09/11/2015 04:55:13 AM (9 years ago)

Author:

dd32

Message:

Translate: Only log translation warnings for translations who are 'current' or 'waiting'. This avoids rejected strings (upon update) being sent.

See #1229

File:

• sites/trunk/translate.wordpress.org/includes/gp-plugins/wporg-log-warnings-to-slack.php (modified) (1 diff)

sites/trunk/translate.wordpress.org/includes/gp-plugins/wporg-log-warnings-to-slack.php

@@ -39 +39 @@
 
     /**
-     * Logs translation warnings into Slack
+     * Logs translation warnings into Slack for any newly created translations.
      *
      * @param  GP_Translation $translatiom The just-created translation.
      */
     function translation_created( $translation ) {
-        if ( $translation->warnings ) {
-            $this->process_translation_warning( $translation );
+        if ( ! $translation->warnings ) {
+            return;
         }
+
+        // We only want to trigger for strings which are live, or are for consideration.
+        if ( ! in_array( $translation->status, array( 'current', 'waiting' ) ) ) {
+            return;
+        }
+
+        $this->process_translation_warning( $translation );
     }
 
+    /**
+     * Logs translation warnings into Slack for any existing translations that are updated.
+     *
+     * @param  GP_Translation $translatiom The just-created translation.
+     */
     function translation_saved( $translation ) {
-        if ( $translation->warnings ) {
-            $this->process_translation_warning( $translation );
+        if ( ! $translation->warnings ) {
+            return;
         }
+
+        // We only want to trigger for strings which are live, or are for consideration.
+        if ( ! in_array( $translation->status, array( 'current', 'waiting' ) ) ) {
+            return;
+        }
+
+        $this->process_translation_warning( $translation );
     }