Changeset 8262 for sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-event/class-event-admin.php

Timestamp:

02/16/2019 12:57:49 AM (8 years ago)

Author:

coreymckrill

Message:

WordCamp Post Type: Ensure status change logs are in English

WCPT's status labels are translatable, but they're also used in logs
when a WordCamp application status changes. Since not all application
reviewers use en_US for their locale, this ensures that the logs are still
readable by everyone.

The WordCamp Reports plugin also relies on status changes being in English.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-event/class-event-admin.php (modified) (4 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-event/class-event-admin.php

@@ -251 +251 @@
 
         /**
+         * Filter: Set the locale to en_US.
+         *
+         * For some purposes, such as internal logging, strings that would normally be translated to the
+         * current user's locale should be in English, so that other users who may not share the same
+         * locale can read them.
+         *
+         * @return string
+         */
+        public function set_locale_to_en_US() {
+                return 'en_US';
+        }
+
+        /**
          * Log when the post status changes
          *
@@ -265 +278 @@
                         return;
                 }
+
+                // Ensure status labels are in English.
+                add_filter( 'locale', array( $this, 'set_locale_to_en_US' ) );
 
                 $old_status = get_post_status_object( $old_status );
@@ -278 +294 @@
                         )
                 );
+
                 // Encoding $post_type and status_change meta ID in key so that we can fetch it if needed while simultaneously be able to have a where clause on value.
                 // Because of the way MySQL works, it will still be able to use index on meta_key when searching, as long as we are querying just the prefix.
@@ -283 +300 @@
                         add_post_meta( $post->ID, "_status_change_log_$post->post_type $log_id", time() );
                 }
+
+                // Remove the temporary locale change.
+                remove_filter( 'locale', array( $this, 'set_locale_to_en_US' ) );
         }