Changeset 8374 for sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-event/class-event-admin.php

Timestamp:

02/28/2019 03:34:07 PM (7 years ago)

Author:

vedjain

Message:

WCPT: Multiple minor fixes. See description.

1. Added check while sending declined / scheduled notifications for WordCamp / Meetup, so that we do not send duplicate notifications for same event.
2. Removed meetup organizer reminder cron because we are not using it anymore. This was already disabled, and this patch just removes dead code from codebase.
3. Applied code standard and fixes in multiple places.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-event/class-event-admin.php (modified) (8 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-event/class-event-admin.php

@@ -259 +259 @@
      * @return string
      */
-    public function set_locale_to_en_US() {
+    public function set_locale_to_en_us() {
         return 'en_US';
     }
@@ -280 +280 @@
 
         // Ensure status labels are in English.
-        add_filter( 'locale', array( $this, 'set_locale_to_en_US' ) );
+        add_filter( 'locale', array( $this, 'set_locale_to_en_us' ) );
 
         $old_status = get_post_status_object( $old_status );
@@ -302 +302 @@
 
         // Remove the temporary locale change.
-        remove_filter( 'locale', array( $this, 'set_locale_to_en_US' ) );
+        remove_filter( 'locale', array( $this, 'set_locale_to_en_us' ) );
     }
 
@@ -315 +315 @@
 
     /**
-     * Schedule notificaiton for declined application. Currently supports WordCamp and Meetup
+     * Schedule notification for declined application. Currently supports WordCamp and Meetup.
      *
      * @param WP_Post $event Event object.
@@ -331 +331 @@
      * @param string $label
      * @param string $location
+     *
+     * @return null|bool|string
      */
     public static function send_decline_notification( $event_id, $label, $location ) {
+        $declined_notification_key = 'sent_declined_notification';
+        if ( get_post_meta( $event_id, $declined_notification_key, true ) ) {
+            return null;
+        }
+
         $message = sprintf(
             'A %s application for %s has been declined, and the applicant has been informed via email.',
@@ -340 +347 @@
 
         $attachment = create_event_status_attachment( $message, $event_id, '' );
-        wcpt_slack_notify( COMMUNITY_TEAM_SLACK, $attachment );
+
+        $notification_sent = wcpt_slack_notify( COMMUNITY_TEAM_SLACK, $attachment );
+        if ( $notification_sent ) {
+            update_post_meta( $event_id, $declined_notification_key, true );
+        }
+        return $notification_sent;
     }
 
@@ -443 +455 @@
 
         // Don't add/remove meta on trash, untrash, restore, etc.
+        // phpcs:ignore WordPress.Security.NonceVerification.Missing
         if ( empty( $_POST['action'] ) || 'editpost' !== $_POST['action'] ) {
             return;
@@ -453 +466 @@
             }
         }
-
 
         $meta_keys = $this->meta_keys();