Changeset 9096 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-review-tools.php

Timestamp:

08/08/2019 10:04:27 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Plugin Directory: Adjust review tools and upload process to better address issues with reserved plugin names and trademark protected slugs:

• Display known problematic IPs more prominently in Author Card.
• Expand the list of reserved slugs and high value slugs.
• Check for trademark protected slugs.
• Block short plugin names (less than 5 characters).
• Clarify that plugin name should be changed in both the main plugin file and readme.

Props Ipstenu.
Fixes #4664.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-review-tools.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-review-tools.php

@@ -33 +33 @@
      */
     public static $reserved_slugs = [
+        'apple',
+        'contact-form-7',
+        'facebook',
+        'google',
+        'instagram',
+        'ios',
+        'jetpack',
+        'jquery',
+        'microsoft',
+        'paypal',
+        'twitter',
+        'woocommerce',
         'wordpress',
-        'woocommerce',
-        'google',
+        'yoast',
         'youtube',
-        'twitter',
-        'facebook',
-        'yoast',
-        'jetpack',
     ];
 
@@ -50 +57 @@
     public static $restricted_slugs = [
         // High-value plugin genres due to their popularity, often abused by spammers.
+        'booking',
+        'bookmark',
+        'cookie',
         'gallery',
         'lightbox',
+        'seo',
         'sitemap',
-        'bookmark',
+        'slide',
         'social',
-        'cookie',
-        'slide',
-        'seo',
 
         // Plugins we generally don't allow.
         'autoblog',
         'auto-blog',
-        'booking',
+        'framework',
+        'library',
         'plugin',
         'spinning',
-        'framework',
     ];
 
@@ -87 +95 @@
 
     /**
-     * List of known problematic IPs
-     *
-     * @var array
-     */
-    public static $iffy_ips = [
-        '2.240.',
-        '2.241.',
-        '5.102.170.',
-        '5.102.171.',
-        '38.78.',
-        '47.15.',
-        '49.50.124.',
-        '65.33.104.38',
-        '71.41.77.202',
-        '76.73.108.',
-        '80.131.192.168',
-        '87.188.',
-        '91.228.',
-        '91.238.',
-        '94.103.41.',
-        '109.123.',
-        '110.55.1.251',
-        '110.55.4.248',
-        '116.193.162.',
-        '119.235.251.',
-        '159.253.145.183',
-        '173.171.9.190',
-        '173.234.140.18',
-        '188.116.36.',
-        '217.87.',
-    ];
-
-    /**
      * Displays links to plugin assets and automated flags.
      */