Plugin Directory: Bad User and Trademarks

[Ipstenu]

This patch attempts to better address ongoing abuse of the WordPress.org services as well as external trademarks.

1. User IPs that are known to be squiffy will now be shown on the more prominent user card instead of the review card. This will help us spot people faster. (NB: This is RARELY used, and really needs a better check, but this will do for now)

2. Reserved slugs and high value slugs have been expanded

3. Clarified language as to where you need to edit the name (main plugin file AND readme please)

4. Check for trademark protected slugs. This will block people using instagram (for example) AT ALL in a plugin URL. This comes at a request from Trademark Owners.

5. Short plugin names will be blocked to prevent SEO abuse.

6. Remove warning about slug since we're blocking them outright now.

Item 4 needs some serious checking. It worked okay in my tests.

[SergeyBiryukov]

In 9096:

Plugin Directory: Adjust review tools and upload process to better address issues with reserved plugin names and trademark protected slugs:

• Display known problematic IPs more prominently in Author Card.
• Expand the list of reserved slugs and high value slugs.
• Check for trademark protected slugs.
• Block short plugin names (less than 5 characters).
• Clarify that plugin name should be changed in both the main plugin file and readme.

Props Ipstenu.
Fixes #4664.

[tobifjellner]

Typo in https://meta.trac.wordpress.org/changeset/9096
Your chosen plugin name - %1$s - is not permitted becuase it is too short. Please change the %2$s line in your main plugin file and readme and upload it again.

[SergeyBiryukov]

In 9097:

Plugin Directory: Fix typo in plugin upload error message if plugin name is too short.

Props tobifjellner.
Fixes #4664.

[tobifjellner]

Sorry, one more:
https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-upload-handler.php?marks=483#L483

Your plugin has been given the initial slug of %2$s based on your diplay name of %1$s. This is subject to change based on the results of your review.

This one was noted by @nabilmoqbel

[SergeyBiryukov]

In 9098:

Plugin Directory: Fix typo in confirmation email after uploading a plugin.

Props nabilmoqbel, tobifjellner.
Fixes #4664.