Opened 9 years ago

Closed 8 years ago

#1054 closed defect (bug) (fixed)

Theme Directory: Theme navigation is out of place for longer strings

Reported by: ocean90's profile ocean90 Owned by: obenland's profile obenland
Milestone: Priority: normal
Component: Theme Directory Keywords: has-patch


See attached screenshot.

Attachments (2)

1054.png (78.9 KB) - added by ocean90 9 years ago.
meta-1054.patch (832 bytes) - added by ramiy 9 years ago.

Download all attachments as: .zip

Change History (9)

9 years ago

#1 @Otto42
9 years ago

.theme-navigation needs a min-width to keep this from happening, however, if any other pages have longer translations, then that width will need to be higher.

Alternatively, .theme-navigation .close can be limited to a max-width as well, though it looks weird when it wraps the text.

#2 @jcastaneda
9 years ago

You could put the navigation below the theme's name on smaller screens.

#3 @ocean90
9 years ago

I just noticed that this happens for the English string as well.

9 years ago

#4 @ramiy
9 years ago

  • Keywords has-patch added; needs-patch removed

The patch has an alternative solution: The arrow before the "Return to Themes List" text, under .close, is hidden on small devices - @media only screen and (max-width: 480px)

It gives us few extra pixels. And not requires us to do any layout changes.

I believe it's a simple and elegant solution.

This ticket was mentioned in Slack in #meta by ramiy. View the logs.

9 years ago

#7 @obenland
8 years ago

  • Owner set to obenland
  • Resolution set to fixed
  • Status changed from new to closed

In 2142: Themes: Prevent theme navigation from wrapping on small screens.

Props ramiy for initial patch.
Fixes #1054.

Note: See TracTickets for help on using tickets.