WordPress.org

Making WordPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#1124 closed defect (fixed)

Use new methods to add custom routes for translate.wordpress.org

Reported by: markoheijnen Owned by: ocean90
Milestone: Priority: highest omg bbq
Component: Translate Site & Plugins Keywords: has-patch
Cc:

Description

I have made some changes in GP_Router which would break on translate.wordpress.org. The changes where needed since it would show the internal implementation. I now added methods that can be used so there is no need to manipulate the $urls property.

See https://glotpress.trac.wordpress.org/changeset/1070

Attachments (2)

1124.diff (2.2 KB) - added by markoheijnen 4 years ago.
1124.2.diff (2.3 KB) - added by markoheijnen 4 years ago.

Download all attachments as: .zip

Change History (6)

@markoheijnen
4 years ago

@markoheijnen
4 years ago

This ticket was mentioned in Slack in #meta-i18n by markoheijnen. View the logs.


4 years ago

#2 @markoheijnen
4 years ago

  • Priority changed from normal to highest omg bbq

#3 @ocean90
4 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 1750:

Translate: Adjust route registration for new API in GlotPress.

props markoheijnen.
fixes #1124.

#4 @ocean90
4 years ago

In 1752:

Translate: Adjust route unregistration for new API in GlotPress.

see #1124.

Note: See TracTickets for help on using tickets.