WordPress.org

Making WordPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#1632 closed defect (fixed)

Remove link from function/hook/whatever title

Reported by: theMikeD Owned by: coffee2code
Milestone: Priority: normal
Component: Developer Hub Keywords: has-patch
Cc:

Description

Example: https://developer.wordpress.org/reference/functions/add_meta_box/

The title should not be a link. It links to itself (which makes no sense) and it makes it difficult to copy a sub-section of it.

Attachments (2)

1632.diff (1.3 KB) - added by chris_dev 4 years ago.
I just replaced href value to "#" cause if I get the anchor tag off, style of the title is broken.
1632.1.diff (4.2 KB) - added by chris_dev 4 years ago.
Remove the anchor tag and change style

Download all attachments as: .zip

Change History (8)

@chris_dev
4 years ago

I just replaced href value to "#" cause if I get the anchor tag off, style of the title is broken.

#1 @chris_dev
4 years ago

  • Keywords has-patch added

Should I get the anchor tag off then modify style sheet?

#2 @theMikeD
4 years ago

I would, yeah. Wrap it in a span and target that for styling. There' no reason for this to be a link at all is there?

@chris_dev
4 years ago

Remove the anchor tag and change style

This ticket was mentioned in Slack in #meta by chris_dev. View the logs.


4 years ago

#4 @coffee2code
4 years ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 2767:

developer.wordpress.org: Don't make the signature header for parsed post types a link.

Props chris_dev.
Fixes #1632.

#5 follow-up: @coffee2code
4 years ago

Thanks for the patch, @chris_dev!

FYI, differences between what was committed and 1632.1.diff:

  • Did not remove link from content-reference-archive.php (visitors need to actually get to pages listed in an archive).
  • Retained bottom-border styling for h1 a:hover links (it still applies for archives).
  • Adjusted text-indent (formerly a margin-left) for the various responsive breakpoints.
  • Made changes to main.scss and regenerated main.css from that. (see the docs for contributing to DevHub for more info about this).
Last edited 4 years ago by coffee2code (previous) (diff)

#6 in reply to: ↑ 5 @chris_dev
4 years ago

Thanks for the advice, This is my first time contribute for Meta.
I will keep it in my mind about scss

Replying to coffee2code:

Thanks for the patch, @chris_dev!

FYI, differences between what was committed and 1632.1.diff:

  • Did not remove link from content-reference-archive.php (visitors need to actually get to pages listed in an archive).
  • Retained bottom-border styling for h1 a:hover links (it still applies for archives).
  • Adjusted text-indent (formerly a margin-left) for the various responsive breakpoints.
  • Made changes to main.scss and regenerated main.css from that. (see the docs for contributing to DevHub for more info about this).
Note: See TracTickets for help on using tickets.