WordPress.org

Making WordPress.org

Opened 3 years ago

Closed 2 years ago

#1749 closed enhancement (fixed)

Update accessibility-ready keyword when uploading an update

Reported by: grapplerulrich Owned by: Otto42
Milestone: Priority: normal
Component: Theme Review Keywords:
Cc:

Description

The accessibility-ready keyword should be automatically be removed from the trac ticket if it is removed from the styles.css.

The change will most likely need to made in WPORG_Themes_Upload::prepare_trac_ticket()`

Change History (4)

#1 @joedolson
3 years ago

Yes, that would be lovely! :)

#2 @grapplerulrich
3 years ago

I think this could be solved with the following code in https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php#L616

<?php
$new_ally_tag = ! isset( $this->theme_post->tags_input['accessibility-ready'] ) && isset( $this->trac_ticket->keywords['accessibility-ready'] );
if ( $this->trac_ticket->priority == 'theme update' && ! new_ally_tag  ) {

#3 @Otto42
3 years ago

  • Owner set to Otto42
  • Status changed from new to assigned

#4 @ocean90
2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 5282:

Theme Directory: Update keywords when uploading an update.

This ensures that the accessibility-ready keyword gets removed if the tag gets removed from the styles.css.
Also remove the comma for multiple keywords.

Props grapplerulrich.
Fixes #1749.

Note: See TracTickets for help on using tickets.