WordPress.org

Making WordPress.org

Opened 3 years ago

Last modified 16 months ago

#1921 reviewing enhancement

Session's date/time on session info page

Reported by: Cheffheid Owned by: coreymckrill
Milestone: Priority: low
Component: WordCamp Site & Plugins Keywords: good-first-bug has-patch has-screenshots needs-testing
Cc:

Description

A session's speaker name is already displaying on a session's page, but once a session is scheduled why doesn't it display the date/time as well?

It helps to have all that information in one place (as opposed to having to refer back to the schedule page for it) and is especially helpful when you've navigated to an entirely different session with the previous/next links.

Attachments (5)

1921.diff (9.3 KB) - added by hlashbrooke 16 months ago.
Displaying all session meta data on sinlge session page
Screenshot_20180216_132525.png (1.1 MB) - added by hlashbrooke 16 months ago.
Example listing all available meta data
Screenshot_20180216_132728.png (1.1 MB) - added by hlashbrooke 16 months ago.
Example listing the minimum most commonly used meta data
1921.1.diff (10.9 KB) - added by hlashbrooke 16 months ago.
Moving meta list into separate view
1921.2.diff (19.7 KB) - added by hlashbrooke 16 months ago.
Updating from master and uncommenting conditional

Change History (13)

#1 @davidjlaietta
3 years ago

As an example: https://2016.orlando.wordcamp.org/session/build-something-today/ Lists the talk title, description, and speaker.

That speaker has been assigned some relevant meta information, most of it visible from https://2016.orlando.wordcamp.org/weekend-schedule/

The individual session page could include the link to slides and wordpress.tv video, date and time of session, and track that the session is in.

#2 @iandunn
3 years ago

  • Keywords needs-patch good-first-bug added
  • Owner set to kovshenin
  • Priority changed from normal to low
  • Status changed from new to assigned

+1

@hlashbrooke
16 months ago

Displaying all session meta data on sinlge session page

#3 follow-up: @hlashbrooke
16 months ago

  • Keywords has-patch has-screenshots needs-testing added; needs-patch removed

I put together a patch for this that displays all the session meta data on the single session page in one list, after the content. See the screenshots below for an example of how it looks - the meta data includes the speaker(s), date, time, track(s), slides URL, video URL and categories, depending on which of those the session actually has.

@hlashbrooke
16 months ago

Example listing all available meta data

@hlashbrooke
16 months ago

Example listing the minimum most commonly used meta data

#4 in reply to: ↑ 3 @davidjlaietta
16 months ago

I think that this handles it very well.

Replying to hlashbrooke:

I put together a patch for this that displays all the session meta data on the single session page in one list, after the content. See the screenshots below for an example of how it looks - the meta data includes the speaker(s), date, time, track(s), slides URL, video URL and categories, depending on which of those the session actually has.

@hlashbrooke
16 months ago

Moving meta list into separate view

#5 @hlashbrooke
16 months ago

After chatting with @iandunn about this, we decided to move the list display to a separate view. The new patch (1921.1.diff) does just that. I used the same method to include the view as elsewhere in the wc-post-types plugin, but let me know if it should eb done differently.

#6 @coreymckrill
16 months ago

  • Owner changed from kovshenin to coreymckrill
  • Status changed from assigned to reviewing

#7 @coreymckrill
16 months ago

@hlashbrooke The patch is looking good. Two things right now:

  • The patch doesn't apply cleanly for me on the latest revision of wc-post-types. Could you check and make sure you've pulled the latest into your dev environment and rebase the patch if necessary?
  • I'm seeing some lines commented out that I'm guessing were changed for local testing, but we probably want them to be interpreted on Production:
// if ( $site_id <= apply_filters( 'wcpt_session_post_speaker_info_min_site_id', 463 ) && ! in_array( $site_id, $enabled_site_ids ) ) { 
//      return $content; 
// }

@hlashbrooke
16 months ago

Updating from master and uncommenting conditional

#8 @hlashbrooke
16 months ago

All sorted @coreymckrill - rebased from master and I uncommented those lines.

Note: See TracTickets for help on using tickets.