Opened 7 years ago

Last modified 5 weeks ago

#1944 new defect (bug)

Plugin Commit Check: Verify License Declarations

Reported by: ipstenu's profile Ipstenu Owned by:
Milestone: Q2 Priority: normal
Component: Plugin Directory Keywords: 2nd-opinion


I know we do some pre-flight checks on plugins before commit (like if the code 'complies' etc). Can we add in a check for readme.txt to verify that there's a line that starts License: and it's _not_ just that?

Like enforce people to actually darn well declare their license or no SVN. That would be a nice way to enforce the CYA :)

Attachments (1)

1944.diff (5.6 KB) - added by Ipstenu 4 years ago.

Download all attachments as: .zip

Change History (11)

#1 @dd32
7 years ago

In [3897] I've started to ingest the license headers into the new plugin directory so we can run some stats to see what kind of impact this change would have.

Early indications are that probably about 50% of popular plugins list it, although they're haphazard in how they list the license (GPLv2 or later vs GPLv2+ vs GNU General Public License v2.0 or later vs GPL V2 or latest vs even GPLv2 or later (of-course) :) )

#2 @Ipstenu
7 years ago

Stage 1: Declare a license.

Stage 2: "As of Date X, your license must be on this list of GPLv2 (or later) compatible terms."?

We could probably get away with "License: GPLv[2|3]*" for much of it. Having to curate a list of acceptable terms would be a pain to start, but once it's done then it's just a mild annoyance.

#3 @Ipstenu
7 years ago

Use to validate license format. If we could somehow automate checking "These are GPLv2+ compatible" that would be brilliant.

#4 @tellyworth
6 years ago

  • Keywords 2nd-opinion added

#5 @tellyworth
5 years ago

  • Milestone set to Q2

4 years ago

#6 @Ipstenu
4 years ago

Uploaded patch 1944.diff - This just checks that new plugins declared a license at all.

#7 @dd32
4 years ago

In 9648:

Plugin Directory: Require a license be specified in the readme.txt.

Props Ipstenu.
Fixes #4719.
See #1944.

#8 @casiepa
4 years ago

See also #5126

#9 @dd32
11 months ago

In 12526:

Plugin Directory: Ingest the License and License URI readme fields on plugin upload.

See #1944, [3897].

#10 @dd32
5 weeks ago

#5126 was marked as a duplicate.

Note: See TracTickets for help on using tickets.