WordPress.org

Making WordPress.org

Opened 3 years ago

Closed 3 years ago

#1983 closed defect (fixed)

Sync users/permissions between base site and team o2

Reported by: ocean90 Owned by:
Milestone: Priority: normal
Component: International Sites (Rosetta) Keywords:
Cc:

Description

Currently new team sites like de.wordpress.org/team have no users. At least editors of the base site should be added to the team o2 as editors.

There are a few (untested) options:

  • Sync only editors when creating a new site.
  • Sync editors when creating a new site and when a new editor is added (use REST API for the sync).
  • Use pre_user_query filter and change blog_id. Doesn't work well if is_user_member_of_blog() is used.

Note: It's a one-way sync.

Change History (9)

#1 @samuelsidler
3 years ago

Sync editors when creating a new site and when a new editor is added (use REST API for the sync).

This seems like a fine option to me, but we should also allow the Editor role on the O2 site to add/remove users, to counter the one-way-ness of this option.

#2 follow-up: @ocean90
3 years ago

Not sure about a two-way sync. Is it a correct assumption that when I add someone to the team site that they can start writing posts for the news blog?

Do we only want to sync editors? What about the other "community/publishing roles" (see #1398)? Should GTEs be an editor on the team site too?

#3 in reply to: ↑ 2 @samuelsidler
3 years ago

Replying to ocean90:

Not sure about a two-way sync. Is it a correct assumption that when I add someone to the team site that they can start writing posts for the news blog?

I don't think we need a two-way sync. I think it's fine if the team site falls out of sync with the main site as long as the team site includes the users from the main site.

Do we only want to sync editors? What about the other "community/publishing roles" (see #1398)? Should GTEs be an editor on the team site too?

I think we only need to sync the Editor role. All other users can already post on team sites and are listed in the autocompleted @-mentions when typing. If Editors can add/remove users, they can add others as-needed.

#4 @ocean90
3 years ago

In this case we should probably first add the Locale Manager role from #1398 and sync only those. This is basically the same as before (all existing Editors will be Locale Managers because back-compat) but should make things more clear.

This ticket was mentioned in Slack in #polyglots by ocean90. View the logs.


3 years ago

#6 @ocean90
3 years ago

In 4030:

Rosetta: Add an editor to the team site when an editor is added to/promoted on the main site.

See #1983.

#7 @ocean90
3 years ago

In 4081:

Rosetta: Don't use get_site_by_path() for fetching the team site.

get_site_by_path() returns the main site if the team site doesn't exist yet because it also searches sites with path = '/'.

See #1983.

#8 @ocean90
3 years ago

In 4082:

Rosetta: Add locale managers as editors to the team site.

See #1983.

#9 @ocean90
3 years ago

  • Keywords needs-patch removed
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [dotorg12432].

Note: See TracTickets for help on using tickets.