Opened 10 years ago

Closed 6 years ago

#249 closed defect (bug) (fixed)

More Plugin API Encoding Issues

Reported by: bpetty's profile bpetty Owned by: dd32's profile dd32
Milestone: Priority: normal
Component: API Keywords: reporter-feedback


The contributors section for this Russian plugin is causing some issues, but the plugin's actual encoding appears to be all valid UTF-8:

The plugin has contributors using same encoding the tags are in, and tags work fine... so whatever tags are doing, it should work for contributors.

It's also interesting to note that it's getting the same treatment in the API that actual usernames get when the API detects that it's an actual username with a profile, but it's definitely not even a valid username, so something is confused there.

Change History (6)

#1 @obenland
6 years ago

  • Keywords reporter-feedback added

The plugin shows up fine in my test install, I wonder if any issue that existed was fixed when the directory was updated recently. Are there any more details on the issues here?

This ticket was mentioned in Slack in #meta by tellyworth. View the logs.

6 years ago

#3 @tellyworth
6 years ago

I'm not sure if it's the same as the original issue, but the contributors are not listed on the plugin page because those in the readme are not valid usernames.

We could do a better job of displaying something helpful when this is the case - perhaps an error message shown to the owner.

#4 @tellyworth
6 years ago

  • Owner set to dd32
  • Status changed from new to reviewing

#5 @dd32
6 years ago

Perhaps we can add a warning to the readme validator when it detects Contributors listed which aren't valid.

We're not going to import any contributor listed which can't be linked to a user here.

Also, worth noting, here's the output for the v1.2 API which is slightly different from the linked response:[slug]=orthodoxcalendarru

#6 @dd32
6 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 7021:

Plugin Directory: Readme Validator: Add a warning when a contributor in the readme is ignored.

Fixes #249.

Note: See TracTickets for help on using tickets.