Making WordPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#2585 closed defect (fixed)

API is returning a different author name than the plugin directory

Reported by: ocean90 Owned by: dd32
Milestone: Plugin Directory v3.0 Priority: high
Component: Plugin Directory Keywords: has-patch


The API seems to return a different author name as the previous API and the front end of the new plugin directory.


Attachments (5)

2585.png (1.1 MB) - added by ocean90 5 years ago.
plugins.png (760.5 KB) - added by hallsofmontezuma 5 years ago.
plugin api.png (415.1 KB) - added by hallsofmontezuma 5 years ago.
plugin api
plugin install.png (246.3 KB) - added by hallsofmontezuma 5 years ago.
plugin install
2585.diff (1.3 KB) - added by obenland 5 years ago.

Change History (16)

5 years ago

#1 @ocean90
5 years ago

  • Owner set to dd32
  • Status changed from new to reviewing

Already chatted with @dd32 about this. He'll take a look at this.

#2 @dd32
5 years ago

  • Status changed from reviewing to accepted

#3 @hallsofmontezuma
5 years ago

On the "View details" link in plugins.php, in addition to the author being wrong (it's the original submitter of the plugin rather than the current author) the link also goes to the wrong website.

It's also incorrect on plugin-install.php, but presumably that info comes from the same place.

Interestingly, at https://api.wordpress.org/plugins/info/1.0/simplemap/, the author URL is correct, and the author name, but not the author profile.

5 years ago


5 years ago

plugin api

5 years ago

plugin install

#4 @Otto42
5 years ago

  • Priority changed from normal to high

Related: #2640

Last edited 5 years ago by Otto42 (previous) (diff)

#5 @Otto42
5 years ago

#2640 was marked as a duplicate.

5 years ago

#6 @obenland
5 years ago

  • Keywords has-patch added; needs-patch removed

@dd32 Is this the right place to fix it?

#7 @dd32
5 years ago

@obenland Looks good to me - I haven't tested it though, verify that it looks good in https://wordpress.org/plugins/wp-json/plugins/v1/plugin/$slug and commit - the caches in the API are ~24hrs though, but any commit or change to an affected plugin will cause that to be cleared.

#8 @Otto42
5 years ago

Might want to add esc_url on it if core doesn't, but other than that, patch looks good.

#9 @dd32
5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 5204:

Plugin Directory: Use the Author and Author URI plugin headers in the API response instead of the original plugin submitters details.
This doesn't change author_profile which still references the original uploaders profile, as it always has. This field doesn't appear to be used by WordPress though.

Props obenland for initial patch.
Fixes #2585.

This ticket was mentioned in Slack in #meta by sergey. View the logs.

5 years ago

Note: See TracTickets for help on using tickets.