Opened 8 years ago
Closed 7 years ago
#2638 closed defect (bug) (wontfix)
Linebreaks in FAQ section
Reported by: | ccprog | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Component: | Plugin Directory | Keywords: | has-patch |
Cc: |
Description
The FAQ section shows all linebreaks from the readme.txt instead of interpreting them according to Markdown rules. Related to #2622?
Attachments (2)
Change History (8)
#2
@
8 years ago
- Keywords has-patch added
Patch would replace line breaks with a space to mitigate instances where line breaks appear after commas of periods.
This is likely not the best approach, maybe there is a setting in our markdown parser that deals with that?
#3
@
8 years ago
I think I looked into something like 2638.diff, but unfortunately IIRC it had unintended consequences (which I can't recall now that it's been so long) - probably specifically about intentional new lines.
Here's how that readme was parsed in the old directory:
<p>There is limited support for use in multisite environments. There is no option for a network wide installation; the plugin <strong>must</strong> be enabled for each individual site. Projects and their associated rights are also specific to the individual site, local administrators have access to these settings as usual.</p>
Here's the readme being parsed in the new directory:
<p>There is limited support for use in multisite environments. There is no option for a network wide installation; the plugin <strong>must</strong> be enabled for each individual site. Projects and their associated rights are also specific to the individual site, local administrators have access to these settings as usual.</p>
I'm assuming that the difference is that we now have WordPress display filters running over the content - probably wpautop()
specifically.
I think I'm okay with this, and am happy to intentionally break anyone who is reliant upon this specific markdown format of new lines. A bunch of plugins will need to update to match the new directory in many ways, I don't see this as being one of those ways as being a bad thing.
If we leave it as-is, it'd probably be best to add a nl2br()
call into the parser to solidify that we're intentionally doing this.
#4
@
8 years ago
I think I looked into something like 2638.diff, but unfortunately IIRC it had unintended consequences (which I can't recall now that it's been so long) - probably specifically about intentional new lines.
Looks to be [4386]
#5
@
8 years ago
I'm seeing this in the plugin descriptions as well (https://wordpress.org/plugins/wordpoints/):
Related: #2257 ?
From https://wordpress.org/plugins/crosswordsearch/