WordPress.org

Making WordPress.org

Opened 4 years ago

Closed 5 months ago

Last modified 5 months ago

#2780 closed enhancement (fixed)

Plugin Directory: Improve Readme Validator styling

Reported by: SergeyBiryukov Owned by: dufresnesteven
Milestone: Priority: normal
Component: Plugin Directory Keywords: has-screenshots ui-feedback needs-patch
Cc:

Description

  • The validator uses the standard WP notice for the success message, but a regular old-style list for error messages. They should be updated to notices as well.
  • Two headings should be combined into one.
  • The layout should be visually consistent with https://wordpress.org/plugins/developers/ (centered column).

Attachments (4)

2780.success.PNG (10.9 KB) - added by SergeyBiryukov 4 years ago.
2780.errors.PNG (49.8 KB) - added by SergeyBiryukov 4 years ago.
readme-validator-markup-2780.diff (2.1 KB) - added by tellyworth 11 months ago.
First attempt at fixing the markup and css issues
Screen Shot 2020-05-20 at 11.32.28 AM.png (363.5 KB) - added by dufresnesteven 5 months ago.
Here's a snap based on @tellyworth's diff

Download all attachments as: .zip

Change History (10)

#1 @melchoyce
3 years ago

  • Keywords ui-feedback added

#2 @tellyworth
3 years ago

  • Keywords needs-patch added

@tellyworth
11 months ago

First attempt at fixing the markup and css issues

#3 @tellyworth
11 months ago

  • Owner set to dufresnesteven
  • Status changed from new to assigned

attachment:readme-validator-markup-2780.diff covers the main issues raised in the ticket.

  • Uses better markup and correct styling for errors and notices
  • Uses h3 for the smaller headings
  • Removed the main dupe heading

Thanks @dufresnesteven for the help!

@dufresnesteven
5 months ago

Here's a snap based on @tellyworth's diff

#4 @dufresnesteven
5 months ago

@SergeyBiryukov Anything missing in the diff that needs to be addressed?

#5 @dufresnesteven
5 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 9919:

Plugins: Update styling for use in readme validator.

Fixes: #2780

#6 @dufresnesteven
5 months ago

In 9920:

Plugins: Update readme validator to use updates error notices.

Props tellyworth, sergeybiryukov
Fixes: #2780

Note: See TracTickets for help on using tickets.