Making WordPress.org

Opened 7 years ago

Closed 7 years ago

#2779 closed defect (bug) (fixed)

Single Plugin: Remove URL to Current Page from Plugin Title

Reported by: bmoredrew's profile bmoredrew Owned by: obenland's profile obenland
Milestone: Priority: normal
Component: Plugin Directory Keywords: has-patch
Cc:

Description

When viewing a single plugin page, the Plugin Title links back to the page you are already viewing, making it difficult to select and poor ux.

Not sure where to get a copy of plugin repo so can't provide a diff.

Line 103 of plugin-single.php:
https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/template-parts/plugin-single.php

Should be replaced with:

<?php the_title( '<h1 class="plugin-title">', '</h1>' ); ?>

Attachments (2)

2779.patch (920 bytes) - added by SergeyBiryukov 7 years ago.
plugin-single-title-fix.patch (1.0 KB) - added by joostdevalk 7 years ago.
Patch that removes link from title on non-advanced page

Download all attachments as: .zip

Change History (11)

#1 follow-up: @SergeyBiryukov
7 years ago

Related: #1887

#2 in reply to: ↑ 1 @bmoredrew
7 years ago

  • Keywords ux-feedback ui-feedback added

Replying to SergeyBiryukov:

Related: #1887

I don't see how they are related. The other ticket seems to be about core navigational items, like a menu.

This just recently changed with some enhancements and now links to the page you're currently on (the single plugin page).

@SergeyBiryukov
7 years ago

#3 @karmatosed
7 years ago

  • Keywords ux-feedback ui-feedback removed

#4 @Ipstenu
7 years ago

  • Milestone Plugin Directory v3.0 deleted
  • Resolution set to maybelater
  • Status changed from new to closed

I'm veto-ing this for now because without that, there's no easy way to get back to the MAIN plugin page from the advanced page. And as a reviewer, that's something we need a lot :)

I think this will be changed as a part of the greater re-design again, but for now, this would cause a lot of lost hours for reviewers.

#5 @joostdevalk
7 years ago

  • Resolution maybelater deleted
  • Status changed from closed to reopened

Reopening this as I was suffering from the same issue, will provide a better patch.

@joostdevalk
7 years ago

Patch that removes link from title on non-advanced page

This ticket was mentioned in Slack in #meta by joostdevalk. View the logs.


7 years ago

#7 @Ipstenu
7 years ago

That'll keep me sane! Thank you!

#8 @obenland
7 years ago

Wow, that file has become quite something.

I'm getting a conflict with the changes from [6232], would you mind refreshing?

#9 @obenland
7 years ago

  • Owner set to obenland
  • Resolution set to fixed
  • Status changed from reopened to closed

In 6469:

Plugins: Only link plugin title when needed.

Props joostdevalk, SergeyBiryukov, bmoredrew.
Fixes #2779.

Note: See TracTickets for help on using tickets.