Opened 7 years ago

Closed 4 years ago

#2854 closed defect (bug) (fixed)

On the Advanced View of a plugin the tabs list is missing

Reported by: ramiy's profile ramiy Owned by: dd32's profile dd32
Milestone: Priority: normal
Component: Plugin Directory Keywords: good-first-bug has-patch


The tabs list navigation (Details, Reviews, Installation, Support, Development) is missing when the Advanced View is displayed.

Attachments (4)

AkismetDetails.png (274.6 KB) - added by ramiy 7 years ago.
AkismetAdvancedView.png (226.7 KB) - added by ramiy 7 years ago.
2854.diff (2.5 KB) - added by audrasjb 6 years ago.
Add plugin main tabs in advanced view page
2854.2.diff (2.6 KB) - added by audrasjb 6 years ago.
Add missing echo instruction to the permalink :P

Download all attachments as: .zip

Change History (12)

7 years ago

#1 @tellyworth
6 years ago

  • Keywords needs-patch good-first-bug added

6 years ago

Add plugin main tabs in advanced view page

#2 @audrasjb
6 years ago

  • Keywords has-patch added; needs-patch removed

Here is a patch to add plugin main tabs in advanced view.
I added plugin permalink to the existing anchors for advanced view only.


6 years ago

Add missing echo instruction to the permalink :P

#3 @joostdevalk
6 years ago

Patch looks good to me, @SergeyBiryukov or @otto42 can you have a look and commit? :)

#4 @Otto42
6 years ago

This doesn't seem like the right way to me. I'd rather get rid of the Advanced view and move its contents somewhere else.

Also, tabs are intentionally missing from the Advanced view. The Advanced view was only created last minute because of internal changes. We need to come up with a bigger and better plan than simply monkey patching this one.

So for now, I say wontfix until we have a better idea.

Last edited 6 years ago by Otto42 (previous) (diff)

#5 @obenland
6 years ago

  • Milestone Plugin Directory v3 - Future deleted
  • Resolution set to maybelater
  • Status changed from new to closed

I agree with everything @Otto42 said. Let's circle back to this when the single plugins page undergoes its next iteration.

#6 @garrett-eclipse
6 years ago

  • Resolution maybelater deleted
  • Status changed from closed to reopened

Hey guys, I know this is a bit old but came across it instead of creating a new ticket.

I found the advanced view setup quite odd and almost becomes a navigation pit as once you're on the Advanced View there's no return or tabs to go back to the main view. Also if you 'favorite' the plugin while on advanced view it reloads the page to the main view. And I also found the Previous Versions hidden at the bottom with stats.

In my opinion I'd propose moving all the contents of the Advanced View aside from the Previous Versions onto a new 'Stats' tab beside the other tabs allowing you to find it and navigate between tabs much easier. As wel the Previous Versions can be moved to Development tab where users expect to find it along with the changelog. I find people asking where it is when they're looking at previous versions and need to revert due to an issue with the current version of the plugin. There was mention in #2875 that previous versions are for advanced users and that's correct but the development tab is where advanced users go, especially if advanced view just becomes Stats and on the Development tab you already fine things like the SVN repo, development log and changelog all of which logically make sense to live together with previous versions.

Proposed Idea in screenshots;
Development tab (w/ Previous Version added, Stats tab and removed Advanced View) -
Stats tab (w/Previous Version removed, tabs added and Advanced View link removed) -

Thanks for the consideration.

#8 @dd32
4 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from reopened to closed

In 9680:

Plugin Directory: Always show the section tabs, including in the Advanced view.

Props audrasjb for initial patch.
Fixes #2854.

Note: See TracTickets for help on using tickets.