WordPress.org

Making WordPress.org

Opened 6 months ago

Closed 5 months ago

#2891 closed defect (fixed)

Plugin Directory Admin: Change "Mark as Pending" to "Pend"

Reported by: Ipstenu Owned by: tellyworth
Milestone: Plugin Directory v3.0 Priority: normal
Component: Plugin Directory Keywords: has-patch
Cc:

Description

tl;dr the text is too long and causes a wrap-around :D

Attachments (5)

2891.diff (782 bytes) - added by Ipstenu 6 months ago.
2891.2.diff (2.0 KB) - added by SergeyBiryukov 6 months ago.
2891.PNG (11.3 KB) - added by SergeyBiryukov 6 months ago.
2891.2.PNG (11.4 KB) - added by SergeyBiryukov 5 months ago.
2891.safari.png (43.6 KB) - added by Ipstenu 5 months ago.
Here's how it CURRENTLY looks on Safari

Download all attachments as: .zip

Change History (16)

@Ipstenu
6 months ago

#1 @SergeyBiryukov
6 months ago

  • Keywords commit added
  • Milestone set to Plugin Directory v3.0

#2 follow-up: @ocean90
6 months ago

  • Keywords commit removed
  • Why is there no text domain for these strings?
  • Not all translators would understand that "Pend" means "Pending", some languages probably don't even have such an abbreviation.
  • Having each button on its own line looks more sane/future-proof.

@SergeyBiryukov
6 months ago

#3 in reply to: ↑ 2 ; follow-up: @SergeyBiryukov
6 months ago

Replying to ocean90:

Why is there no text domain for these strings?

My bad, missed in [5573].

Having each button on its own line looks more sane/future-proof.

That was my initial thought as well, it just looked a bit weird, so I went with a single row in the first iteration.

2891.2.diff adds the text domain and moves each button to its own line: 2891.PNG.

P.S. On WCEU contributor day I've noticed that creating patches from the root of the meta repository causes them to not apply properly. What would be the preferred root directory? sites/trunk/wordpress.org/public_html/, maybe?

#4 in reply to: ↑ 3 @ocean90
6 months ago

Replying to SergeyBiryukov:

P.S. On WCEU contributor day I've noticed that creating patches from the root of the meta repository causes them to not apply properly. What would be the preferred root directory? sites/trunk/wordpress.org/public_html/, maybe?

I personally don't have the sites directory in my SVN checkout because it's unnecessary. I guess that's the reason why the git mirror doesn't even have that extra directory.


2891.2.diff looks good.

Last edited 6 months ago by ocean90 (previous) (diff)

#5 @Ipstenu
6 months ago

Having each button on its own line looks more sane/future-proof.

God, I really hope we don't have more than 3 at any one point in time. Each on it's own line is clutter to me.

We used to just have four (let it ride, reply to author, reject, approve), but we don't need one 'let it ride' anymore since that's the draft status, and if we just save it does that.

#6 @coffee2code
5 months ago

@Ipstenu: Are you on board with having each button on its line, perhaps with a revisit should we ever get 4+ there and it becomes too cluttered for you?

#7 follow-up: @Ipstenu
5 months ago

I'd rather not have it be each on their own line, since that makes it look really bad on mobile (yes, I review plugins on my phone sometimes).

If it has proper padding, I don't mind the wrap-around, but right now it's only got side-side padding, and nothing for top-bottom.

#8 in reply to: ↑ 7 @SergeyBiryukov
5 months ago

Replying to Ipstenu:

If it has proper padding, I don't mind the wrap-around, but right now it's only got side-side padding, and nothing for top-bottom.

Here's how it looks for me in Chrome dev tools' iPhone 5 emulation: 2891.2.PNG. Do you see something different? Could you add a screenshot?

#9 @SergeyBiryukov
5 months ago

Moved the patch for missing text domains to a separate ticket: #2993.

Last edited 5 months ago by SergeyBiryukov (previous) (diff)

@Ipstenu
5 months ago

Here's how it CURRENTLY looks on Safari

#10 @Ipstenu
5 months ago

Chrome would be why :) I use Safari and it looks like https://meta.trac.wordpress.org/attachment/ticket/2891/2891.safari.png on laptop and iOS.

#11 @tellyworth
5 months ago

  • Owner set to tellyworth
  • Resolution set to fixed
  • Status changed from new to closed

In 5715:

Plugin directory admin: improve buttons in the Plugin Controls metabox. Props @SergeyBiryukov

Fixes #2891

Note: See TracTickets for help on using tickets.