WordPress.org

Making WordPress.org

Opened 7 months ago

Closed 6 weeks ago

Last modified 4 weeks ago

#2934 closed defect (fixed)

Coming Soon Page doesn't completely hide WordCamp content

Reported by: RMarks Owned by: RMarks
Milestone: Priority: low
Component: WordCamp Site & Plugins Keywords: good-first-bug has-patch needs-testing
Cc:

Description

While setting up https://2017.birmingham.wordcamp.org and while the Coming Soon Page was enabled, I happened to share https://2017.birmingham.wordcamp.org/call-for-vounteers/ in Slack and saw the details of the page because of the Open Graph tags.

See https://wordpress.slack.com/archives/C02QB8GMM/p1499361698479917 where I brought this up and a bit of discussion.

Should the Coming Soon Page option block 100% of the site's content?

Attachments (5)

coming-soon-open-graph.PNG (37.7 KB) - added by RMarks 7 months ago.
Source of page while logged out.
2934-partial.diff (1.5 KB) - added by RMarks 6 months ago.
2934-jetpack.diff (1.5 KB) - added by RMarks 6 months ago.
Disable Jetpack's Open Graph meta tags when the Coming Soon page is active
2934-jetpack.2.diff (1.5 KB) - added by RMarks 6 months ago.
Disable Jetpack's Open Graph meta tags when the Coming Soon page is active
2934-rest-api.diff (3.2 KB) - added by RMarks 6 weeks ago.
Disable REST API

Download all attachments as: .zip

Change History (20)

@RMarks
7 months ago

Source of page while logged out.

#1 @coreymckrill
7 months ago

  • Keywords needs-patch good-first-bug added
  • Owner set to coreymckrill
  • Status changed from new to accepted

Thanks for the report @RMarks ! I imagine that there is some meta data in the document header that we would want to keep, but certainly the Open Graph stuff doesn't need to be there when Coming Soon mode is enabled (unless maybe the Open Graph data should just be updated to reflect the mode?) It also seems to me that the RSS feed and the REST API shouldn't reveal post content while Coming Soon is active.

@RMarks
6 months ago

#2 @RMarks
6 months ago

  • Summary changed from Coming Soon Page doesn't complete hide WordCamp content to Coming Soon Page doesn't completely hide WordCamp content

I've attached a diff that partially addresses the issues in this ticket. The diff removes the Open Graph tags added by Jetpack. I welcome feedback on this part.

I'm looking for suggestions on what's the best way to filter the published posts from the various feeds (/feed, /comments/feed) and search (/?s=) when the Coming Soon option is enabled.

Thanks!

#4 @coreymckrill
6 months ago

@RMarks the patch looks good. The only thing I would recommend, and it's fairly minor, is that instead of wp_loaded you use an action hook that's a little bit closer to when the jetpack_enable_open_graph hook gets fired (which happens during wp_head). The template_redirect hook, for example. That way, it's more likely the routine will only run on requests that are relevant to its functionality. With wp_loaded the routine will run on nearly all requests, including those for backend WP Admin screens.

@RMarks
6 months ago

Disable Jetpack's Open Graph meta tags when the Coming Soon page is active

#5 @RMarks
6 months ago

Thanks @coreymckrill. I've updated the hook and attached a new diff based on your suggestion.

I'm also still looking for suggestions on the second part of my post from comment 2 above.

Last edited 6 months ago by RMarks (previous) (diff)

@RMarks
6 months ago

Disable Jetpack's Open Graph meta tags when the Coming Soon page is active

#6 @coreymckrill
6 months ago

@RMarks for the feeds, you'll want to short-circuit them using the "do_feed_{$feed}" action hooks. See the do_feed() function in Core.

For the search, I don't have any suggestions off the top of my head, other than to look for some similar action or filter hook that you can use to stop the search before it runs.

This ticket was mentioned in Slack in #meta by rmarks. View the logs.


6 months ago

#8 @grapplerulrich
6 months ago

@RMarks My suggestion would be to use $feed = get_default_feed(); and add_action( "do_feed_{$feed}", function(){} );

#9 @coreymckrill
5 months ago

In 5801:

WordCamp Coming Soon: Disable JP OpenGraph when Coming Soon enabled

Prevents Jetpack from adding OpenGraph meta tags to document headers
while the Coming Soon page is enabled on a site. These tags were leaking
content from sites while they were still under construction.

Refs #2934
Props RMarks

#10 @coreymckrill
4 months ago

  • Owner changed from coreymckrill to RMarks
  • Status changed from accepted to assigned

#11 @iandunn
3 months ago

  • Priority changed from normal to low

@RMarks
6 weeks ago

Disable REST API

#12 @RMarks
6 weeks ago

  • Keywords has-patch needs-testing added; needs-patch removed

I worked with @briandichiara and @icaleb at WCUS Contributor Day to identify what filter to use to disable the REST API. Today, if you browse to /wp-json/wp/v2/pages/ or another REST endpoint, you'll see the following error:

{"code":"rest_cannot_access","message":"The REST API has been disabled while in Coming Soon mode.","data":{"status":403}}

Last edited 6 weeks ago by RMarks (previous) (diff)

#13 @coreymckrill
6 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 6226:

WordCamp Coming Soon: Disable anonymous REST requests in Coming Soon mode

This prevents the REST API from sending successful responses to unauthenticated
requests while Coming Soon mode is active, thus preventing the site's content
from being publicly accessible via REST.

Props RMarks, icaleb, briandichiara
Fixes #2934

This ticket was mentioned in Slack in #meta-wordcamp by rmarks. View the logs.


6 weeks ago

This ticket was mentioned in Slack in #meta-wordcamp by coreymckrill. View the logs.


4 weeks ago

Note: See TracTickets for help on using tickets.