Opened 7 years ago

Closed 4 years ago

Last modified 4 years ago

#3033 closed enhancement (fixed)

Change microcopy of "Submit changes" button

Reported by: francina's profile francina Owned by: dd32's profile dd32
Milestone: Priority: normal
Component: Trac Keywords: needs-patch


when you leave a comment on trac the Submit Changes button is not relevant because you are not changing anything. It could be changed to "Submit".

Change History (9)

#1 @obenland
6 years ago

Hi francina, thanks for your suggestion!

I think the "change" part in the button text refers to the ticket overall, where adding a comment changes it?

#2 @francina
6 years ago

Thank you for the reply!

Yes that's technically true, but it's not very clear when I'm only submitting a comment and not "changing" any of the properties of the ticket. It's quite confusing.

Maybe a dynamic value for the button text could work. If the user has only entered a comment it could say "Submit Comment". If the user changes one of the ticket's fields then it could say "Submit Changes".

#3 @obenland
6 years ago

I understand how it can give first time contributors pause, but don't you think that fades away after submitting the first comment?

#4 @francina
6 years ago

What if I told you that I almost didn't submit my first ticket because I was utterly afraid of messing things up? :)

We have been discussing how to propose changes to things in the Community team and Trac comes up regularly as "too technical", so for example for Meta tickets we do a post on the P2 and then "someone technical" comes here and follows up.

Not a priority, but it would be nice to hear some different point of views, also from the inclusive language perspective: I had such conversations with a bunch of people in the past year and to be honest also the imperative "Submit!" is not really great.

I'll reach out to people that I know are invested in the topic and see if they have some valuable feedback, what do you think?

This ticket was mentioned in Slack in #meta by obenland. View the logs.

6 years ago

#6 follow-up: @tellyworth
6 years ago

Would changing the button to Submit be an improvement on the current situation? If so, let's do that. If not, I think this might be a maybelater ticket for next time we put some effort into Trac.

#7 in reply to: ↑ 6 @francina
6 years ago

I don't think "Submit" will be an improvement, but "Publish" definitely.

#8 @dd32
4 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 9628:

Trac: Rename the "Submit changes" button for nonGardeners to "Add Comment".

Fixes #3033.

#9 @dd32
4 years ago

In 9629:

Trac: Bump scripts version after [9628].

See #3033.

Note: See TracTickets for help on using tickets.