WordPress.org

Making WordPress.org

Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#3075 closed defect (fixed)

Meetings: Add "Biweekly" option

Reported by: SergeyBiryukov Owned by: SergeyBiryukov
Milestone: Priority: normal
Component: Make (Get Involved) / P2 Keywords: has-patch
Cc:

Description

Background #2916

On https://make.wordpress.org/meetings/, some teams (Themes, Docs, Community) have biweekly meetings, but the "Next Meeting" column lists them as either weekly or monthly due to the lack of a "Biweekly" option in the Meeting Post Type plugin.

If anyone wants to take a stab, the plugin is here: sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-meeting-posttype.

Attachments (2)

3075.patch (3.5 KB) - added by ketuchetan 3 months ago.
3075.2.patch (3.5 KB) - added by SergeyBiryukov 3 months ago.

Download all attachments as: .zip

Change History (10)

#1 @SergeyBiryukov
3 months ago

  • Keywords needs-patch added

@ketuchetan
3 months ago

#2 @ketuchetan
3 months ago

  • Keywords has-patch added; needs-patch removed

Hi @SergeyBiryukov

I have added my patch.

Once, you get the time please review it and let me know if any changes on that.

#3 @SergeyBiryukov
3 months ago

  • Summary changed from Add "Biweekly" option to make.wordpress.org/meetings to Meetings: Add "Biweekly" option

Related: #2218

#4 @SergeyBiryukov
3 months ago

3075.patch is a good start, but doesn't work as expected: if the start date is 2015-05-14 and the current date is 2017-08-29, it displays the next meeting date as 2016-07-07.

3075.2.patch addresses that by mirroring the monthly option logic. And while were at it:

  • Adds missing id attribute for radio buttons to properly associate them with the labels.
  • Puts the labels after radio buttons instead of before, for consistency with the rest of WP admin.

Should be good to go.

#5 @ketuchetan
3 months ago

Hello @SergeyBiryukov

Thanks for the correction and I will be taking care on next time.

Again, many thanks :)

This ticket was mentioned in Slack in #meta-wordcamp by sergey. View the logs.


3 months ago

#7 @SergeyBiryukov
3 months ago

  • Resolution set to duplicate
  • Status changed from new to closed

#2218 has a newer patch that includes "Biweekly" option. Left a note there about props for @ketuchetan.

#8 @SergeyBiryukov
3 months ago

  • Owner set to SergeyBiryukov
  • Resolution changed from duplicate to fixed

In 5849:

Make/Meetings: Add "Biweekly" option for recurrent meetings.

Props ketuchetan for initial patch.
Fixes #3075. See #2218.

Note: See TracTickets for help on using tickets.