WordPress.org

Making WordPress.org

Opened 7 months ago

Closed 7 months ago

#3252 closed defect (fixed)

Trac viewer interprets HTML entities

Reported by: obenland Owned by:
Milestone: Priority: normal
Component: Make (Get Involved) / P2 Keywords:
Cc:

Description

The trac ticket previewer seems to interpret HTML entities in pingback titles as valid ticket numbers.

See https://make.wordpress.org/marketing/2017/11/02/marketing-to-community-november-1-2017-meeting-notes/#comment-285

First reported in #core42456.

Change History (4)

#1 @Otto42
7 months ago

I'm not seeing it. Where are you seeing the links going to a trac there?

I see the gravatar hovercard being wrong, but no trac links.

#2 @obenland
7 months ago

Hover over the pingback title, it'll bring up an empty hover box where the ticket info would be in.
See screenshot in #core42456

#3 @Otto42
7 months ago

Yes, I see the hoverbox. I'm just not sure why it has anything to do with trac links. The words core.trac don't appear anywhere in the page source. The trac links code in the plugin only affects the_content and comment_text filters, not the whole page. And an Inspect of that doesn't show me any trac links.

I'm not really sure why the code is adding that hovercard at all, since that's a pingback and there's nothing for it to show in the hover in the first place. So, might be an error in the hovercard code or something.

#4 @obenland
7 months ago

  • Keywords needs-patch removed
  • Resolution set to fixed
  • Status changed from new to closed

The pingback title contains HTML entities (–) where I assume the regex picked up the #8211 part and tried to convert it. Fixed in [dotorg13561] by limiting it to only anchors that link to Trac.

Note: See TracTickets for help on using tickets.