Making WordPress.org

Opened 2 years ago

Last modified 14 months ago

#3740 assigned defect

WordCamp.org: cancelled camps visible with URL

Reported by: sippis Owned by: sippis
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: good-first-bug has-patch needs-testing


For example, WC Rhode Island (post ID 3057593) is marked as "Cancelled", but still visible when accessing the URL https://central.wordcamp.org/wordcamps/wordcamp-ri-usa/. It shouldn't since it is canceled, right?

Attachments (3)

3740.diff (1.2 KB) - added by sippis 18 months ago.
3740.2.diff (5.0 MB) - added by sippis 15 months ago.
3740.3.diff (5.0 MB) - added by sippis 15 months ago.

Change History (10)

This ticket was mentioned in Slack in #meta-wordcamp by sippis. View the logs.

21 months ago

#2 @iandunn
21 months ago

  • Keywords needs-patch good-first-bug added
  • Owner set to sippis
  • Status changed from new to assigned

#3 @sippis
21 months ago

Today in WC bug scrub Ian said (note ro me for doing patch)

Probably just need to update that old theme template to use the new WordCamp_Loader::get_public_post_statuses()
(i'm not sure if i'm remembering the class/function name exactly right, but it's something similar to that)

#4 @sippis
18 months ago

  • Keywords has-patch needs-testing added; needs-patch removed

This was a somewhat larger issue than I expected. Looks like you can access to every WordCamp info page on central.wordcamp.org regardless of its status.

Does every old WordCamp have a status? In WME WC's didn't have any status so also valid old camps did start giving a 404. A quick look on the production version WC list gives a feeling that every camp has a status, but this needs to be double-checked before applying the patch to production.

Patch extends existing query_public_statuses_on_archives function in wcpt plugin to limit singular WordCamp views on central.wordcamp.org/wordcamps/* to view only camps with public status. I extended the existing function to check also singular views, because it made more sense than adding a new check to new function.

18 months ago

This ticket was mentioned in Slack in #meta-wordcamp by sippis. View the logs.

18 months ago

15 months ago

#6 @sippis
15 months ago

Updated diff:

  • renamed function query_public_statuses_on_archives to query_public_statuses for consisteny
  • better inline documentation

15 months ago

This ticket was mentioned in Slack in #meta-wordcamp by iandunn. View the logs.

14 months ago

Note: See TracTickets for help on using tickets.