Opened 6 years ago

Closed 6 years ago

#3799 closed defect (bug) (fixed)

`/announce` and `/here` do not work for newer users

Reported by: dd32's profile dd32 Owned by: dd32's profile dd32
Milestone: Priority: normal
Component: Communication (Matrix, Slack, IRC) Keywords:


As reported in Slack #meta some users are unable to use the /announce and /here commands despite being whitelisted.

This is because Slack changed awhile ago to deprecate the user_name field:

As done elsewhere in our Slack API code, the proper thing to do here is to determine the user by the slack user_id and convert that back into a WordPress user_login before comparing it to the whitelists.

Change History (4)

#1 @dd32
6 years ago

In 7661:

Slack: When comparing a slack user to the user whitelist, determine the user by comparing the Slack ID to our slack database prior to using the deprecated user_name slack field.

This should allow users who sign up after a certain date to be whitelisted for /announce and /here commands.

See #3799.

#2 @dd32
6 years ago

In 7662:

Slack: Correct r7661 to use a DB query to get the user_login as WordPress isn't loaded for these APIs (although $wpdb exists).

See #3799.

#3 @dd32
6 years ago

In 7663:

Slack: Update the Announce whitelists to consistently use usernames rather than non-unique deprecated slack user_names.

See #3799.

#4 @dd32
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

Based on feedback in I'm going to close this as working.

Note: See TracTickets for help on using tickets.