WordPress.org

Making WordPress.org

Opened 8 months ago

Closed 7 months ago

Last modified 7 weeks ago

#3885 closed task (fixed)

Missing Gutenprops

Reported by: JeffPaul Owned by: pento
Milestone: Priority: high
Component: API Keywords:
Cc:

Description

As @jorbin noted in #core Slack, the r43815 commit is missing some props from the Gutenmerge.

I've created a Google Sheet to try and help track the Gutenprops. It currently has a tab noting those who received props as part of the r43815 commit and another tab noting those who show as having commits to the Gutenberg repo on GitHub using git log (see attached commits.rtf file from @jorbin as of 23 Oct 2018 at 20:54 UTC).

We'll also want to capture the GitHub contributors noted https://github.com/WordPress/gutenberg/graphs/contributors and https://github.com/WordPress/gutenberg/blob/master/CONTRIBUTORS.md. We'll may also want to capture GitHub users who created an Issue that had a related merged PR as a valid contribution that deserves a prop. I haven't thought at length on this, but there may be other places to capture contributions to Gutenberg that should be included in the Gutenprops list.

Eventually, we'll need to identify the wp.org username for those GitHub names/emails/usernames and get those added as part of the 5.0 credits update.

I'll unfortunately be offline for the next two weeks and won't be able to help on this again until I'm back, but wanted to get this analysis started so we have time to add missing props in time for the 5.0 release.

Attachments (1)

commits.rtf (14.5 KB) - added by JeffPaul 8 months ago.
GitHub git log

Download all attachments as: .zip

Change History (22)

@JeffPaul
8 months ago

GitHub git log

#1 @audrasjb
8 months ago

Hi,
We are 5-6 people who volunteered to bless this task.
I already get in touch with @JeffPaul to see how we can handle that efficiently.

Last edited 8 months ago by audrasjb (previous) (diff)

#2 @chanthaboune
8 months ago

  • Owner set to chanthaboune
  • Status changed from new to assigned

#3 in reply to: ↑ description ; follow-up: @coffee2code
8 months ago

Replying to JeffPaul:

We'll may also want to capture GitHub users who created an Issue that had a related merged PR as a valid contribution that deserves a prop.

I'll preface this by acknowledging that each team is free to decide on the criteria used to award their contributor badge. However, merely filing a ticket to raise a valid issue that was eventually fixed/implemented has not warranted a contributor badge for core or meta in the past. Props are generally granted for material participation to a commit (code, designs/mockups, a11y recommendations, copy, notable research, audits, user testing, insightful debugging or analysis, etc).

Reporting a bug in and of itself hasn't automatically earned people a contributor badge and I personally don't see why it should be any different for Gutenberg. (Again, participation in the fix/implementation beyond filing a ticket for the bug/request is where the contribution effort begins to warrant badging.)

#4 @JeffPaul
7 months ago

I've gone through the Contributors.md file and attempted to match those to existing props from r43815 and found the following three issues.
1) Some wp.org usernames listed in r43815 were incorrect and we'll want to ensure props are given for the correct names:

  • Looks like "ephox-mogran" was incorrectly given props, this should instead have been "ephoxmogran" who needs to be added to the Gutenberg props listing.
  • Looks like "ianstewart" was incorrectly given props, this should instead have been "ianstewart" who needs to be added to the Gutenberg props listing.
  • Looks like "GaryJones" was incorrectly given props, this should instead have been "garyj" who needs to be added to the Gutenberg props listing.
  • Looks like "jasonagnew" was incorrectly given props, this should instead have been "jagnew" who needs to be added to the Gutenberg props listing.

2) Some names from Contributors.md weren't able to be matched to a wp.org username, so any further help on matching those users would be helpful to ensure they're properly propped:

  • Unable to find additional data on the "inhil" GitHub account and thus cannot match to an existing wp.org username.
  • Unable to find additional data on the "vladanost" GitHub account and thus cannot match to an existing wp.org username. Note that this may be https://www.linkedin.com/in/vladanostojic/.

3) Some names from Contributors.md we totally missing from the r43815 props listing and we'll want to ensure props are given for them:

  • "joyously" needs to be added to the Gutenberg props listing
  • "mayukojpn" needs to be added to the Gutenberg props listing
  • "lukepettway" needs to be added to the Gutenberg props listing
  • "pratikthink" needs to be added to the Gutenberg props listing
  • "MaedahBatool" needs to be added to the Gutenberg props listing
  • "luehrsen" needs to be added to the Gutenberg props listing
  • "mikeschroder" needs to be added to the Gutenberg props listing
  • "greatislander" needs to be added to the Gutenberg props listing
  • "sharaz" needs to be added to the Gutenberg props listing
  • "jakeparis" needs to be added to the Gutenberg props listing

That leaves the final part of the analysis of trying to match the GitHub emails from the git log to existing wp.org usernames (details here). If someone from the Meta team can help with that, then I can check those wp.org usernames against those from r43815 and confirm if any further Gutenberg props are needed.

#5 @audrasjb
7 months ago

@JeffPaul some people in the fr_FR team offered their time to try a systematic manual check on profile.wordpress.org to match w.org profiles with usernames provided by the git log.

If that suits you, I can make a copy of the spreadsheet and we can start that work.

#6 @JeffPaul
7 months ago

@audrasjb that would be great, was just hoping there was a quicker automated way to match those emails to usernames.

#7 @coffee2code
7 months ago

@JeffPaul granted me access to the Google Sheet. I've updated the last column (which I re-labeled to "Associated wp.org account") to provide the w.org usernames for the accounts that use the same listed GitHub email address. That gets us 218 out of the 374 users listed.

When I get a chance a little later I'll go through and see if I can fill in the gaps.

#8 follow-up: @coffee2code
7 months ago

I've gone through the spreadsheet and associated 349 of the 374 users with a w.org username (by comparing git email addresses, GitHub handles, personal recognition, and good old fashioned web sleuthing). The remaining 25 either don't have a w.org account or the association to an account wasn't discernible given the information available or that I could find. The list is as complete as I can get it.

#9 @coffee2code
7 months ago

I figured out 2 more account associations. For the remaining 23, I've added a "GitHub Handle" value when I could find it (only 2 are blank). 4 of these unknown/no-association belong to variations of the same account.

For real this time, this has been my final effort barring any additional requests.

#10 in reply to: ↑ 8 @DrewAPicture
7 months ago

Replying to coffee2code:

I've gone through the spreadsheet and associated 349 of the 374 users with a w.org username (by comparing git email addresses, GitHub handles, personal recognition, and good old fashioned web sleuthing). The remaining 25 either don't have a w.org account or the association to an account wasn't discernible given the information available or that I could find. The list is as complete as I can get it.

Wow! Nice work @coffee2code!

#11 @pento
7 months ago

  • Owner changed from chanthaboune to pento

Nice work, everyone! I'm going to merge this list into the credits list.

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


7 months ago

#13 @pento
7 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

I manually added this list to the credits API, so everyone appears on the credits list.

#15 follow-up: @pento
7 months ago

Not too late at all, you're on the list now.

#16 in reply to: ↑ 15 @JoshuaWold
7 months ago

Replying to pento:

Not too late at all, you're on the list now.

Thanks!

This ticket was mentioned in Slack in #core-committers by peterwilsoncc. View the logs.


7 months ago

#18 in reply to: ↑ 3 @SergeyBiryukov
7 months ago

Replying to coffee2code:

Reporting a bug in and of itself hasn't automatically earned people a contributor badge and I personally don't see why it should be any different for Gutenberg. (Again, participation in the fix/implementation beyond filing a ticket for the bug/request is where the contribution effort begins to warrant badging.)

FWIW, per the core contributor handbook, the Core Team now tends to give props to reporters of valid bugs regardless of further participation:

In the case of bug reports, props should also be given to the reporter of the bug.
...
Err on the side of giving props liberally. Props provide major encouragement for contributors.

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


7 weeks ago

#21 @SergeyBiryukov
7 weeks ago

  • Component changed from General to API
Note: See TracTickets for help on using tickets.