WordPress.org
Get WordPress

Making WordPress.org

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#3889 closed defect (bug) (fixed)

Plugin Embeds: Download link not working

Reported by: swissspidy's profile swissspidy Owned by:
Milestone: Priority: normal
Component: Plugin Directory Keywords:
Cc:

Description

For various reasons, WordPress embeds (oEmbed) from a domain like example.com cannot contain links to URLs on any other host. Only links with identical hosts are allowed. See ​https://github.com/WordPress/WordPress/blob/da7a80d67fea29c2badfc538bfc01c8a585f0cbe/wp-includes/js/wp-embed.js#L82-L87 for the source code.

Plugin embeds contain a "Get this plugin" link that leads to download.wordpress.org/…. However, since plugins are embedded from wordpress.org, the link won't work.

Suggestion: just link to the plugin page or use something like https://wordpress.org/plugins/<plugin>/download/ that then redirects to the ZIP file for download.

Plugin embeds were introduced/optimized in #1396.

Change History (3)

This ticket was mentioned in ​Slack in #core by swissspidy. ​View the logs.
6 years ago

#2 @Otto42
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

[7793] until we come up with something better

#3 @SergeyBiryukov
6 years ago

In 7796:

Plugins: After [7793], use get_permalink() so that esc_url() could work as expected.

See #3889.

Note: See TracTickets for help on using tickets.